Remove old debug stack context

Author: apfelbox

src/Normalizer/SimpleNormalizer.php

@@ -24,7 +24,6 @@
 class SimpleNormalizer
 {
 	private readonly ?ClassMetadataFactory $doctrineMetadata;
-	private const string STACK_CONTEXT = "simple-normalizer.debug-stack";
 	private const int DEFAULT_MAX_DEPTH = 128;
 
 	/** @var array<class-string, class-string> */
@@ -53,7 +52,7 @@ public function __construct (
 	 */
 	public function normalize (mixed $value, array $context = []) : mixed
 	{
-		$stack = $this->extractInitialStack($context);
+		$stack = [];
 		$normalizedValue = $this->recursiveNormalize($value, $context, $stack);
 
 		if ($this->isDebug)
@@ -68,7 +67,7 @@ public function normalize (mixed $value, array $context = []) : mixed
 	 */
 	public function normalizeArray (array $array, array $context = []) : array
 	{
-		$stack = $this->extractInitialStack($context);
+		$stack = [];
 		$normalizedValue = $this->recursiveNormalizeArray($array, $context, $stack);
 
 		if ($this->isDebug)
@@ -86,7 +85,7 @@ public function normalizeArray (array $array, array $context = []) : array
 	public function normalizeMap (array $array, array $context = []) : array|\stdClass
 	{
 		// return stdClass if the array is empty here, as it will be automatically normalized to `{}` in JSON.
-		$stack = $this->extractInitialStack($context);
+		$stack = [];
 		$normalizedValue = $this->recursiveNormalizeArray($array, $context, $stack) ?: new \stdClass();
 
 		if ($this->isDebug)
@@ -144,9 +143,6 @@ private function recursiveNormalize (mixed $value, array $context, array &$stack
 					$normalizer = $this->objectNormalizers->get($className);
 					\assert($normalizer instanceof SimpleObjectNormalizerInterface);
 
-					// Preserve debug stack visibility for custom object normalizers.
-					$context[self::STACK_CONTEXT] = $stack;
-
 					return $normalizer->normalize($value, $context, $this);
 				}
 				catch (ServiceNotFoundException $exception)
@@ -229,25 +225,4 @@ private function recursiveNormalizeArray (array $array, array $context, array &$
 
 		return $result;
 	}
-
-	/**
-	 * @return list<string>
-	 */
-	private function extractInitialStack (array $context) : array
-	{
-		if (!isset($context[self::STACK_CONTEXT]) || !\is_array($context[self::STACK_CONTEXT]))
-		{
-			return [];
-		}
-
-		$stack = [];
-
-		foreach ($context[self::STACK_CONTEXT] as $entry)
-		{
-			\assert(\is_string($entry));
-			$stack[] = $entry;
-		}
-
-		return $stack;
-	}
 }

tests/Normalizer/ObjectNormalizer/ValueWithContextNormalizerTest.php

@@ -36,10 +36,6 @@ public function testContextPassing () : void
 				[
 					"test" => 123,
 					"o" => "hai",
-					"simple-normalizer.debug-stack" => [
-						get_debug_type($value),
-						DummyVO::class,
-					],
 				],
 			);
 
@@ -68,10 +64,6 @@ public function testEmptyWrappedContextKeepsIncomingContext () : void
 				$value->value,
 				[
 					"test" => 123,
-					"simple-normalizer.debug-stack" => [
-						get_debug_type($value),
-						DummyVO::class,
-					],
 				],
 			);
 
@@ -101,10 +93,6 @@ public function testEmptyIncomingContextUsesWrappedContext () : void
 				$value->value,
 				[
 					"o" => "hai",
-					"simple-normalizer.debug-stack" => [
-						get_debug_type($value),
-						DummyVO::class,
-					],
 				],
 			);