From 585a89093600ec4a44b753d8466b336fa3bfb234 Mon Sep 17 00:00:00 2001 From: Echo Date: Fri, 31 Jul 2026 09:27:25 -0400 Subject: [PATCH] fix: janky login handoff --- scripts/byoe/login-handoff.js | 15 ++++++++++----- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/scripts/byoe/login-handoff.js b/scripts/byoe/login-handoff.js index a8d6d87..ff748b7 100644 --- a/scripts/byoe/login-handoff.js +++ b/scripts/byoe/login-handoff.js @@ -8,11 +8,16 @@ const isSlackUrl = (v) => typeof v === 'string' && /^slack:/i.test(v); const isEphemeralArg = (v) => isSlackUrl(v) || v === '--test-type=webdriver' || v === '--userAgent'; function registerSlackProtocol(setter) { - return setter( - PROTOCOL, - process.execPath, - [...process.execArgv, ...process.argv.slice(1)].filter((a) => !isEphemeralArg(a)), - ); + const registered = + process.platform === 'darwin' + ? setter(PROTOCOL) + : setter( + PROTOCOL, + process.execPath, + [...process.execArgv, ...process.argv.slice(1)].filter((a) => !isEphemeralArg(a)), + ); + if (registered === false) console.error('[slick-byoe] could not register as the slack:// handler'); + return registered; } const originalSetDefault = app.setAsDefaultProtocolClient.bind(app);