Skip to content

⚡ [optimize microtubule torus instanced mesh]#43

Open
jason420247 wants to merge 1 commit into
masterfrom
⚡-optimize-microtubule-torus-instanced-mesh-jules-5365801355714529380-3297e1cd

Hidden character warning

The head ref may contain hidden characters: "\u26a1-optimize-microtubule-torus-instanced-mesh-jules-5365801355714529380-3297e1cd"
Open

⚡ [optimize microtubule torus instanced mesh]#43
jason420247 wants to merge 1 commit into
masterfrom
⚡-optimize-microtubule-torus-instanced-mesh-jules-5365801355714529380-3297e1cd

Conversation

@jason420247

Copy link
Copy Markdown
Collaborator

💡 What:
Refactored the MicrotubuleTorus component in components/QuantumScene.tsx to utilize THREE.InstancedMesh instead of individual mesh instances.

🎯 Why:
Rendering hundreds or thousands of individual meshes (360 + 720 in the default scene) was extremely expensive due to excessive draw calls. Using InstancedMesh consolidates these into just 2 draw calls for the toruses (3 total for the scene including lights/background), significantly improving rendering performance.

📊 Measured Improvement:

  • Draw Call Reduction: Reduced from 1,080 draw calls to 3 draw calls.
  • CPU Efficiency: Matrix updates are now performed using a single, reusable THREE.Object3D, reducing object allocation overhead during the animation loop.
  • Frustum Culling: Set frustumCulled={false} to prevent flickering during rapid animations where bounding box calculations might lag.

PR created automatically by Jules for task 5365801355714529380 started by @jason420247

- Refactor `MicrotubuleTorus` to use `THREE.InstancedMesh`.
- Reduce draw calls from 1,080 to 3 for torus rendering.
- Use a reusable `Object3D` in the `useFrame` loop for efficient matrix updates.
- Set `frustumCulled={false}` on `InstancedMesh` to ensure visibility during complex transformations.

Co-authored-by: jason420247 <44763042+jason420247@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant