Fix https->http redirects.#366
Open
sleaze wants to merge 1 commit into
Open
Conversation
…tion cast in downloader thread. Also allow up to 2 redirects.
metaprime
reviewed
Dec 19, 2016
metaprime
left a comment
metaprime
left a comment
Collaborator
There was a problem hiding this comment.
Could you add more description about what issue this is fixing? Could you provide a URL which results in this code path, or add a test?
|
|
||
| URL urlToDownload = this.url; | ||
| boolean redirected = false; | ||
| boolean redirectedAgain = false; |
Collaborator
There was a problem hiding this comment.
Why not use a counter instead of two separate booleans?
| // Setup HTTP request | ||
| HttpURLConnection huc; | ||
| if (this.url.toString().startsWith("https")) { | ||
| if (urlToDownload.toString().startsWith("https")) { |
Collaborator
There was a problem hiding this comment.
Is this set somewhere besides urlToDownload = this.url? If not, this is basically just renaming the variable used, correct? Just want to make sure.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensure appropiate procotol variable is referenced to determine connection cast in downloader thread.
Also allow up to 2 redirects.