TGReact loop

[jrood-nrel]

PeleC/Exec/RegTests/TGReact/prob.cpp

Lines 187 to 189 in b3264de

	for (int lev = 0; lev <= finest_level; lev++) {
	max_temp = maxDerive("Temp", time, local_flag);
	}

Copilot found some unnecessary looping. It thinks it should be something like getLevel(lev).maxDerive(...) with a running max, but it's not obvious to me exactly what it should be.

[baperry2]

Yeah, this bit of code is definitely wrong as is.

It should look like what we do here:

PeleC/Source/SumIQ.cpp

Line 167 in 8c83f01

for (int lev = 0; lev <= finest_level; lev++) {

Or we could make the code more readable by just deriving a whole multifab and then using the multifab max command rather than doing a local max then manually doing the parallel communication for some reason.