`unreachable-code-return` compile errors with LLVM 22.1.6

[urvangjoshi]

What version / commit were you testing with?

87aa8dc

What steps will reproduce the problem?

Build AVM LLVM 22.1.6

CC=${HOME}/Downloads/LLVM-22.1.6-Linux-X64/bin/clang CXX=${HOME}/Downloads/LLVM-22.1.6-Linux-X64/bin/clang++ cmake ../avm  -DENABLE_WERROR=1        && make -j100

What is the expected output?

No errors

What do you see instead?

A number of -Wunreachable-code-return errors:

/tmp/avm/av2/av2_dx_iface.c:1339:14: error: 'return' will never be executed [-Werror,-Wunreachable-code-return]                                                          
 1339 |       return cm->error.error_code;                                                                                                                                                                         
      |              ^~                                                                                                                                                                                            
/tmp/avm/av2/av2_dx_iface.c:1396:16: error: 'return' will never be executed [-Werror,-Wunreachable-code-return]                                                          
 1396 |         return cm->error.error_code;                                                                                                                                                                       
      |                ^~                       

...

/tmp/avm/av2/decoder/decoder.c:505:12: error: 'return' will never be executed [-Werror,-Wunreachable-code-return]                                                        
  505 |     return AVM_CODEC_ERROR;                                                                                                                                                                                
      |            ^~~~~~~~~~~~~~~                                                                                                                                                                                 
/tmp/avm/av2/decoder/decoder.c:535:12: error: 'return' will never be executed [-Werror,-Wunreachable-code-return]                                                        
  535 |     return AVM_CODEC_ERROR;                                                                                                                                                                                
      |            ^~~~~~~~~~~~~~~                                                                                             

...


/tmp/avm/av2/av2_cx_iface.c:3681:16: error: 'return' will never be executed [-Werror,-Wunreachable-code-return]                                                          
 3681 |         return cm->error.error_code;                                                                                                                                                                       
      |                ^~                              

....

/tmp/avm/av2/decoder/decodeframe.c:9543:13: error: 'return' will never be executed [-Werror,-Wunreachable-code-return]                                                   
 9543 |     return -1;                                                                                                                                                                                             
      |             ^                                                                                                                                                                                              
/tmp/avm/av2/decoder/decodeframe.c:9537:13: error: 'return' will never be executed [-Werror,-Wunreachable-code-return]                                                   
 9537 |     return -1;                                                                                                                                                                                             
      |             ^                                                                                                                                                                                              
/tmp/avm/av2/decoder/decodeframe.c:9530:13: error: 'return' will never be executed [-Werror,-Wunreachable-code-return]                                                   
 9530 |     return -1;

....

/tmp/avm/av2/encoder/bitstream.c:6840:12: error: 'return' will never be executed [-Werror,-Wunreachable-code-return]
 6840 |     return 0;                               
      |            ^                                
/tmp/avm/av2/encoder/bitstream.c:6831:12: error: 'return' will never be executed [-Werror,-Wunreachable-code-return]
 6831 |     return 0;                               
      |            ^                                
/tmp/avm/av2/encoder/bitstream.c:6919:12: error: 'return' will never be executed [-Werror,-Wunreachable-code-return]
 6919 |     return 0;                               
      |            ^                                
/tmp/avm/av2/encoder/bitstream.c:6910:12: error: 'return' will never be executed [-Werror,-Wunreachable-code-return]
 6910 |     return 0;