From 0d0e1a36599fc2fb72bc488c21d661da2c13ae63 Mon Sep 17 00:00:00 2001
From: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Date: Wed, 29 Apr 2026 13:47:43 +0000
Subject: [PATCH] fix: address Devin Review findings on datadog-synthetics
 workflow

- Add step-level condition to skip Datadog Synthetic tests when
  DD_API_KEY/DD_APP_KEY secrets are not configured, preventing CI failure
- Use more specific tag (ci-required-e2e) instead of generic e2e-tests
  to reduce accidental scope changes via Datadog tag edits
- Rename job from 'build' to 'e2e-tests' for clarity

Co-Authored-By: Thuong Huynh <admin@huynhthuong.online>
---
 .github/workflows/datadog-synthetics.yml | 12 +++++-------
 1 file changed, 5 insertions(+), 7 deletions(-)

diff --git a/.github/workflows/datadog-synthetics.yml b/.github/workflows/datadog-synthetics.yml
index 66c70f8..ffba166 100644
--- a/.github/workflows/datadog-synthetics.yml
+++ b/.github/workflows/datadog-synthetics.yml
@@ -20,19 +20,17 @@ on:
     branches: [ "main" ]
 
 jobs:
-  build:
+  e2e-tests:
     runs-on: ubuntu-latest
 
     steps:
     - uses: actions/checkout@v4
 
-    # Run Synthetic tests within your GitHub workflow.
     # For additional configuration options visit the action within the marketplace: https://github.com/marketplace/actions/datadog-synthetics-ci
     - name: Run Datadog Synthetic tests
+      if: ${{ secrets.DD_API_KEY != '' && secrets.DD_APP_KEY != '' }}
       uses: DataDog/synthetics-ci-github-action@87b505388a22005bb8013481e3f73a367b9a53eb # v1.4.0
       with:
-        api_key: ${{secrets.DD_API_KEY}}
-        app_key: ${{secrets.DD_APP_KEY}}
-        test_search_query: 'tag:e2e-tests' #Modify this tag to suit your tagging strategy
-
-
+        api_key: ${{ secrets.DD_API_KEY }}
+        app_key: ${{ secrets.DD_APP_KEY }}
+        test_search_query: 'tag:ci-required-e2e'