diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md new file mode 100644 index 0000000..692ea70 --- /dev/null +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -0,0 +1,55 @@ +# Mood Analysis +Congratulations! You're submitting your assignment. Before submitting your updated Ruby Code please answer the questions below from the README. + +### What's Happening? +Explain what is happening on each of the following lines in the code. + +| Line # | What's happening? +|:------:|------------------- +| 1 | +| 2 | +| 3 | +| 6 | +| 7-8 | +| 9 | +| 10 | +| 11 | +| 12 | +| 13 | +| 14 | +| 18-24 | + +### Data Types +What's the Data Type of the following? + +| Code | Data Type +|----------------------------|----------- +| FEELINGS | +| :sad | +| happy | +| words | +| words.split(" ") | +| FEELINGS[:sad] | +| FEELINGS[:happy].include? | +| analyze_mood(text) | + +### Explaining the Code +| Question | Answer +|------------------------|------- +| Why do we need line 9? | +| What is the relationship between `words` and `word` (line 10)? | +| Why doesn't line 22 have an associated if/condition? | +| What is the relationship between `text[0]`, `text[1]`, and `words`? | + + +## Comprehension Questions + + + +| Question | Answer | +|--- |--- | +| Why does 03/13 come out as neutral when it should be happy? How could we fix this? | | +| Where should we call strip_punctuation? Does it matter? Why? | | +| What are you going to do if there aren't at least 3 happy days? Where do you need to handle that case? | | +| In the `overall_mood` function would it make more sense to use an Array or a Hash to determine the most common mood? Why? | | +| What if we eventually want to add feelings to our analysis? For example if we wanted to add 'angry' or 'excited' to the list of feelings in the analysis? Can we write this code in a way that will prevent us from having to re-write it later? |