From fb81ea3509ea172d71597b418a10d58ec973f7f2 Mon Sep 17 00:00:00 2001 From: Chris M Date: Fri, 20 Jan 2017 16:29:19 -0800 Subject: [PATCH 1/3] Created Pull Request Template --- .github/PULL_REQUEST_TEMPLATE.md | 12 ++++++++++++ 1 file changed, 12 insertions(+) create mode 100644 .github/PULL_REQUEST_TEMPLATE.md diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md new file mode 100644 index 0000000..03b42a1 --- /dev/null +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -0,0 +1,12 @@ +# Mood Analysis +Congratulations! You're submitting your assignment. + +## Comprehension Questions + +| Question | Answer | +|--- |--- | +| Why does 03/13 come out as neutral when it should be happy? How could we fix this? | | +| Where should we call strip_punctuation? Does it matter? Why? | | +| What are you going to do if there aren't at least 3 happy days? Where do you need to handle that case? | | +| Should you use an array or a hash to solve this problem? Why? | | +| What if we eventually want to add feelings to our analysis? Can we write this code in a way that will prevent us from having to re-write it later? | | From 1665c6afe6be1ae4c20f82ece7c2c99d2d7524da Mon Sep 17 00:00:00 2001 From: Chris M Date: Mon, 23 Jan 2017 09:41:47 -0800 Subject: [PATCH 2/3] Responding to Kari's input --- .github/PULL_REQUEST_TEMPLATE.md | 47 ++++++++++++++++++++++++++++++-- 1 file changed, 45 insertions(+), 2 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 03b42a1..7ae1662 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -1,12 +1,55 @@ # Mood Analysis Congratulations! You're submitting your assignment. +### What's Happening? +Explain what is happening on each of the following lines in the code. + +| Line # | What's happening? +|:------:|------------------- +| 1 | +| 2 | +| 3 | +| 6 | +| 7-8 | +| 9 | +| 10 | +| 11 | +| 12 | +| 13 | +| 14 | +| 18-24 | + +### Data Types +What's the Data Type of the following? + +| Code | Data Type +|----------------------------|----------- +| FEELINGS | +| :sad | +| happy | +| words | +| words.split(" ") | +| FEELINGS[:sad] | +| FEELINGS[:happy].include? | +| analyze_mood(text) | + +### Explaining the Code +| Question | Answer +|------------------------|------- +| Why do we need line 9? | +| What is the relationship between `words` and `word` (line 10)? | +| Why doesn't line 22 have an associated if/condition? | +| What is the relationship between `text[0]`, `text[1]`, and `words`? | + + ## Comprehension Questions + + | Question | Answer | |--- |--- | | Why does 03/13 come out as neutral when it should be happy? How could we fix this? | | | Where should we call strip_punctuation? Does it matter? Why? | | | What are you going to do if there aren't at least 3 happy days? Where do you need to handle that case? | | -| Should you use an array or a hash to solve this problem? Why? | | -| What if we eventually want to add feelings to our analysis? Can we write this code in a way that will prevent us from having to re-write it later? | | +| In the `overall_mood` function would it make more sense to use an Array or a Hash to determine the most common mood? Why? | | +| What if we eventually want to add feelings to our analysis? For example if we wanted to add 'angry' or 'excited' to the list of feelings in the analysis? Can we write this code in a way that will prevent us from having to re-write it later? | From 5bb73ba9e6f17b37333caa0eabcad8fca211b398 Mon Sep 17 00:00:00 2001 From: Chris M Date: Mon, 23 Jan 2017 09:42:59 -0800 Subject: [PATCH 3/3] A bit of direction at the top --- .github/PULL_REQUEST_TEMPLATE.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 7ae1662..692ea70 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -1,5 +1,5 @@ # Mood Analysis -Congratulations! You're submitting your assignment. +Congratulations! You're submitting your assignment. Before submitting your updated Ruby Code please answer the questions below from the README. ### What's Happening? Explain what is happening on each of the following lines in the code.