You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
There are several costs to ember-table supporting legacy platforms, and we're ready for a major release.
Contributors keep stumbling on the legacy use of sendAction in this codebase (most recently at add columns array to onReorder() and onResize() #818). Today we cannot remove sendAction since it is required for Ember 1.12 and this library supports Ember 1.12.
Additionally this library supports IE11 despite that browser being extremely uncommon in modern usage. Indeed at Addepar we no longer have a need to support IE11, and I think we're one of the last.
As part of an effort to update the ember-cli-sass version used here and elsewhere we make changes in Drop the legacy style build steps addepar-style-toolbox#38 which may alter how the SASS of an application works (no longer would an example app have a patched @import to import only once, instead an application should provide that functionality itself if desired).
The plan & progress
The repo now has a branch 3.0-beta, in draft state at #831. We will land patches for an eventual 3.0 release into that branch, and will make incremental beta releases along the way. Already you can find v3.0.0-4 released via NPM.
I propose a list of changes before a 3.0 final is declared. The task list is:
Motivation
There are several costs to ember-table supporting legacy platforms, and we're ready for a major release.
sendActionin this codebase (most recently at add columns array to onReorder() and onResize() #818). Today we cannot removesendActionsince it is required for Ember 1.12 and this library supports Ember 1.12.<div>)ember-cli-sassversion used here and elsewhere we make changes in Drop the legacy style build steps addepar-style-toolbox#38 which may alter how the SASS of an application works (no longer would an example app have a patched@importto import only once, instead an application should provide that functionality itself if desired).The plan & progress
The repo now has a branch
3.0-beta, in draft state at #831. We will land patches for an eventual 3.0 release into that branch, and will make incrementalbetareleases along the way. Already you can findv3.0.0-4released via NPM.I propose a list of changes before a 3.0 final is declared. The task list is:
ember-try.jshttps://github.com/Addepar/ember-table/blob/master/config/ember-try.js#L13sendAction, instead call passed-in functions directly. Basically avoid sendAction when possible #825 but only the non-Ember-1.13 codepaths.Deprecations/send action #801RemovesendActionAPI #860 should be able to be closed.ember-table/addon/-private/sticky/legacy-sticky-polyfill.js
Line 4 in 70d0960
package.jsonember-raf-scheduler#870ember-cli-sass3.0labeled issues or pull requests: Issues & PRs filtered here.