fix: skip building faq.json when faq.yml is empty

Author: softwareentrepreneer

afterpython/_website/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@afterpython/project-website-template",
-	"version": "0.3.1",
+	"version": "0.3.2",
 	"license": "Apache-2.0",
 	"type": "module",
 	"scripts": {

afterpython/_website/src/routes/faq/+page.server.ts

@@ -1,4 +1,3 @@
-import { error } from '@sveltejs/kit';
 import type { PageServerLoad } from './$types';
 
 export const prerender = true;
@@ -9,11 +8,13 @@ type FaqItem = {
 	category?: string;
 };
 
+const FILE = 'faq' as const;
+
 export const load: PageServerLoad = async () => {
 	try {
-		const faq = await import('$static/faq.json');
+		const faq = await import(`$static/${FILE}.json`);
 		return { faq: (faq.default ?? faq) as FaqItem[] };
 	} catch {
-		throw error(404, 'FAQs are not available for this project.');
+		return { faq: [] as FaqItem[] };
 	}
 };

src/afterpython/builders/faq_json.py

@@ -24,20 +24,21 @@ def build_faq_json():
         click.echo("No faq.yml found, skip building faq.json")
         return
 
-    click.echo("Building faq.json...")
-
     raw = read_yaml(faq_yml_path)
     if raw is None:
-        items: list[dict] = []
-    else:
-        items = [
-            {
-                "question": str(item["question"]),
-                "answer": str(item["answer"]),
-                "category": str(item["category"]) if item.get("category") else "",
-            }
-            for item in raw
-        ]
+        click.echo("faq.yml is empty, skip building faq.json")
+        return
+
+    click.echo("Building faq.json...")
+
+    items = [
+        {
+            "question": str(item["question"]),
+            "answer": str(item["answer"]),
+            "category": str(item["category"]) if item.get("category") else "",
+        }
+        for item in raw
+    ]
 
     with open(build_path / "faq.json", "w") as f:
         json.dump(items, f, indent=2)