Skip to content

Commit 3be5c3b

Browse files
fix: mystmd doesn't support .svg for favicon, use .ico instead
1 parent 276686f commit 3be5c3b

11 files changed

Lines changed: 4586 additions & 277 deletions

File tree

165 KB
Binary file not shown.

afterpython/_website/static/favicon.svg

Lines changed: 1 addition & 1 deletion
Loading

afterpython/_website/static/logo.svg

Lines changed: 1 addition & 1 deletion
Loading

afterpython/afterpython.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ url = "https://afterpython.org" # used in myst.yml's venue.url
55

66
[website]
77
url = "https://afterpython.afterpython.org"
8-
favicon = "favicon.svg"
8+
favicon = "favicon.ico"
99
logo = "logo.svg"
1010
logo_dark = "logo.svg"
1111
thumbnail = "thumbnail.png" # thumbnail for the website, also used as default thumbnail for all content types, e.g. blog posts, tutorials, examples, and guides

afterpython/doc/myst.yml

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ project:
1818
title: 'AfterPython.Org'
1919
url: https://afterpython.org
2020
# To autogenerate a Table of Contents, run "myst init --write-toc"
21-
copyright: © AfterPython.Org 2025. All rights reserved.
21+
copyright: © AfterPython.Org 2026. All rights reserved.
2222
# title:
2323
description: CLI tool to streamline Python package maintenance and generate a dedicated project website
2424
keywords:
@@ -50,11 +50,12 @@ project:
5050
- file: references/roadmap.md
5151
- file: CONTRIBUTING.md
5252
title: ''
53+
thumbnail: ../static/thumbnail.png
5354
site:
5455
template: book-theme
5556
# See options at: https://mystmd.org/guide/website-templates#site-options
5657
options:
57-
favicon: ../static/favicon.svg
58+
favicon: ../static/favicon.ico
5859
logo: ../static/logo.svg
5960
logo_dark: ../static/logo.svg
6061
logo_text: afterpython

afterpython/static/favicon.ico

165 KB
Binary file not shown.

pixi.lock

Lines changed: 3029 additions & 132 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

pixi.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ pyproject-metadata = ">=0.11.0"
3535
# jupytext = ">=1.18.1"
3636
# jinja2 = ">=3.1.6"
3737
mystmd = ">=1.9.0"
38-
pdoc = ">=16.0.0"
38+
great-docs = ">=0.9"
3939
ruff = ">=0.15.12"
4040
pre-commit = ">=4.6.0"
4141
commitizen = ">=4.13.10"

pyproject.toml

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -44,18 +44,13 @@ dependencies = [
4444
# "jupytext>=1.18.1",
4545
# "jinja2>=3.1.6",
4646
"mystmd>=1.9.0",
47-
"pdoc>=16.0.0",
47+
"great-docs>=0.9",
4848
"ruff>=0.15.12",
4949
"pre-commit>=4.6.0",
5050
"commitizen>=4.13.10",
5151
# "python-semantic-release>=10.5.2",
5252
]
5353

54-
[dependency-groups]
55-
dev = [
56-
"afterpython>=0.2.1",
57-
]
58-
5954
[project.urls]
6055
homepage = "https://afterpython.afterpython.org"
6156
repository = "https://github.com/AfterPythonOrg/afterpython"

src/afterpython/cli/commands/sync.py

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -58,6 +58,10 @@ def sync():
5858
website_favicon = normalize_static_path(
5959
str(_from_tomlkit(afterpython.get("website", {})).get("favicon", ""))
6060
)
61+
if website_favicon and not website_favicon.lower().endswith(".ico"):
62+
raise ValueError(
63+
f"Invalid favicon '{website_favicon}': mystmd only supports .ico files."
64+
)
6165
website_logo = normalize_static_path(
6266
str(_from_tomlkit(afterpython.get("website", {})).get("logo", ""))
6367
)
@@ -100,6 +104,8 @@ def sync():
100104
# based on the current values in pyproject.toml and afterpython.toml
101105
for content_type in CONTENT_TYPES:
102106
path = ap.paths.afterpython_path / content_type
107+
if not (path / "myst.yml").exists():
108+
continue
103109
# nav_bar_per_content_type = [
104110
# item for item in nav_bar if item["title"] != content_type.capitalize() + "s"
105111
# ]

0 commit comments

Comments
 (0)