Composition when variables have exact same names

[TeikiRaihauti]

The transformation from Crop2ML to cs (and bioma and sirius) can have problems :

• If in the composite XML, two variables from differents model units have the same name, the component in C# doesn't connect correctly these variables.

For example :

• This line won't create problems
  InternalLink target="SoilTemperatureSWAT.iSurfaceSoilTemperature" source="SurfaceTemperatureSWAT.SurfaceSoilTemperature"

• But this one will have problems (it won't create the variable in the Auxiliary class if it is considered an auxiliary)
  InternalLink target="SoilTemperatureSWAT.SurfaceSoilTemperature" source="SurfaceTemperatureSWAT.SurfaceSoilTemperature"

[cyrillemidingoyi]

@TeikiRaihauti @pradal
From my point of view, if two model units share a variable with the same name, then this should mean that they refer to the same semantic variable. In that case, the transformation should treat it as a single variable, independently of the component in which it appears, and the connection is simply a = a.

If they are actually different variables, then they should not have the same name in the Crop2ML description. In other words, variables should be defined independently of the components that use them, or they should be explicitly distinguished when they represent different concepts.

For example, soil Tmax and air Tmax should not be given the same variable name in the Soil and Climate components, because they do not represent the same quantity.

[cyrillemidingoyi]

@TeikiRaihauti @pradal If you find that my answer is correct I can close this issue

[TeikiRaihauti]

@cyrillemidingoyi I understand your answer. However, in the algorithm we can still have issues :
If we have
InternalLink target="SoilTemperatureSWAT.SurfaceSoilTemperature"
source="SurfaceTemperatureSWAT.SurfaceSoilTemperature"

and SurfaceSoilTemperature as a "state" in "SurfaceTemperatureSWAT", and SurfaceSoilTemperature as an "auxiliary" in "SoilTemperatureSWAT, then in the algorithm of "SoilTemperatureSWAT" we will have something like :

SurfaceTemperature = a.SurfaceTemperature

but then it should be

SurfaceTemperature = s.SurfaceTemperature