Some corrections for cs transformation

[TeikiRaihauti]

• If the keyword "out" is used in function call, then it has to appear also in the function signature
• If multiple loop use the "i" variable and it is declared, the loop should not be "var i = 0; i...." but "i = 0; i..."
• "int" cast is done for "Math.Ceil" but not for "Math.Floor"
• Not sure about this one, but may be a good idea to check that if we have 2 auxiliary functions with similar names (for example "dothermalcond" and "dothermalcondcoef"), then be sure both will be added to the code. I had this problem but not sure if it comes from CyMLTh process or if it comes from Crop2ML.

[cyrillemidingoyi]

@TeikiRaihauti for each case, could you point to the corresponding line in the component code in the soiltemperature repository?

[cyrillemidingoyi]

@TeikiRaihauti, why do you want to cast Math.floor?

[cyrillemidingoyi]

@TeikiRaihauti , I do not understand your last case. In APSIM soiltemperature, neither dothermalcond nor dothermalcondcoef are auxiliary functions. These functions are implemented inside the auxiliary functions "doProcess" and "readParam". Only the functions called inside the algorithm of the modelUnit are defined as "auxiliary functions"

[TeikiRaihauti]

@TeikiRaihauti for each case, could you point to the corresponding line in the component code in the soiltemperature repository?

They are not in the soiltemperature repo, theses obervations come from components transformed using AI. I will send to you some examples that caused problems.

@TeikiRaihauti, why do you want to cast Math.floor?

Here is a pyx function :
def _fortran_nint(float x):
cdef int result
if x >= 0.0:
result = floor(x + 0.5)
else:
result = ceil(x - 0.5)
return result

Here is the transformation in cs :
public static int _fortran_nint(double x)
{
int result;
if (x >= 0.0)
{
result = Math.Floor(x + 0.5);
}
else
{
result = (int)Math.Ceiling(x - 0.5);
}
return result;
}

When transforming in cs, the cast for the Math.Ceiling() method is done automatically but not the Math.Floor() one.

@TeikiRaihauti , I do not understand your last case. In APSIM soiltemperature, neither dothermalcond nor dothermalcondcoef are auxiliary functions. These functions are implemented inside the auxiliary functions "doProcess" and "readParam". Only the functions called inside the algorithm of the modelUnit are defined as "auxiliary functions"

Oh, I get it. Well in the automatic transformation with AI, I consider any function as an auxiliary one (even the one only called inside auxiliary function). Doing this, we reduce redundancy if a function is used by multiple auxiliary function. I will also format my files and send you some examples.