Possible build improvement

[sbernard31]

This is just a list of possible improvement.

1. use maven to check if code is well formatted e.g : Add formatter-maven-plugin to ensure file are well formatted.  eclipse-leshan/leshan#1281
2. use maven to check unused import and ensure there are sorted correctly : Add impsort-maven-plugin to ensure Java imports are well sorted. eclipse-leshan/leshan#1282
3. use maven to check pom is well sort/formatted : Add sortpom-maven-plugin to ensure pom.xml files are well formatted. eclipse-leshan/leshan#1285
4. maven enforcer can be used to check build requirement (examples)
5. maven compiler could be configured to raise more error/warning.
6. Generally better to fix all version dependency and plugin dependency respectively in <dependencyManagement> and <pluginManagement>
7. author and license can be put in pom.xml
8. flatten-maven-plugin is cool to have complete pom.xml by jar (but maybe too soon to do that and not needed with maven 4 if I get it correctly)

Also to be use to use last version of plugin you can use

<plugin>
    <groupId>org.codehaus.mojo</groupId>
    <artifactId>versions-maven-plugin</artifactId>
    <version>2.19.1</version>
</plugin>

and mvn versions:display-dependency-updates to check dependency
and mvn versions:display-plugin-updates to check plugin dependency

[sbernard31]

I also see that project encoding is not defined :

<leshan.encoding>UTF-8</leshan.encoding>
<project.build.sourceEncoding>${leshan.encoding}</project.build.sourceEncoding>
<project.reporting.outputEncoding>${leshan.encoding}</project.reporting.outputEncoding>

[bplessis-swi]

Indeed thoses would be good.
Flatten option is the "fatjar" mechanism no ? for a library this feel a bit weird, especially since the project should be as lightwieght as possible on the dependency side

[sbernard31]

Flatten option is the "fatjar" mechanism no ? for a library this feel a bit weird, especially since the project should be as lightwieght as possible on the dependency side

I'm not sure to know what is "flatjar" but I'm using it to create complete a pom.xml which all data without reference to parent pom.

So in your source code you can have a complex pom.xml hierarchy to factorize build config.
Then when you build you create a jar with a complete independent pom. (so not need to deliver parent pom)
Here is the more or less the idea : https://blog.frankel.ch/maven-flatten-plugin/

here also a reason to use flatten : https://stackoverflow.com/questions/58521838/how-to-deploy-child-module-without-also-deploying-parent-module/72830959#72830959

[sbernard31]

I see there are a .gitignore in each sub project.
Maybe better to put all in the root one ?

[sbernard31]

About

Generally better to fix all version dependency and plugin dependency respectively in and

This can also be use to force usage of a more recent version of ProProt : aws/elastic-load-balancing-tools#73

I tested with 33.5.0-jre and tests seem to run.