Check rclcpp::ok before sleeping for clean shutdown (backport moveit#3484) (moveit#3485)

Author: mergify[bot]

moveit_ros/planning/planning_scene_monitor/src/planning_scene_monitor.cpp

@@ -492,6 +492,9 @@ void PlanningSceneMonitor::scenePublishingThread()
       planning_scene_publisher_->publish(msg);
       if (is_full)
         RCLCPP_DEBUG(LOGGER, "Published full planning scene: '%s'", msg.name.c_str());
+      // finish thread on rclcpp shutdown (otherwise rate.sleep() will crash)
+      if (!rclcpp::ok())
+        break;
       rate.sleep();
     }
   } while (publish_planning_scene_);