text_energy icon doesn't work in card library (custom keyword hover tips)

[Kakamisan]

card_keyword desc format like this: "... {energyPrefix:energyIcons(1)} ..."
Log:
[WARN] No energy prefix found for EnergyIconsFormatter! Using colorless as a fallback.

[sethmcleod]

Does Energy:energyIcons() work for you? That's how I'm rendering my custom tooltips.

[Kakamisan]

Does Energy:energyIcons() work for you? That's how I'm rendering my custom tooltips.

No, Energy:energyIcons() work on smart desc tips, but card_keyword tips(Add with HoverTipFactory.FromKeyword(something)) are static. If in a running game, {energyPrefix:energyIcons(1)} always work and rendering true icons, only problem that it doesn't work in card library that click from main menu.

[sethmcleod]

Good catch! I was testing this while running the game on a modded character, but I can reproduce the issue you found from the main menu card library. Here's a short description of the root cause:

BaseLib gives the keyword tooltip an empty energy prefix:

// CustomTooltips.cs
description.Add("energyPrefix", "");

When the prefix is empty, the game asks the current character for the icon:

// EnergyIconsFormatter
if (string.IsNullOrEmpty(text) || text == "colorless")
    text = RunManager.Instance.GetLocalCharacterEnergyIconPrefix();

In a run, there is a character, so the icon is correct. In the card library there is no run, so this returns null. That is why you get the colorless icon and the warning.

Card descriptions work because they do not use the run. They use the card's own pool:

// CardModel.cs
description.Add("energyPrefix", EnergyIconHelper.GetPrefix(this));

Workaround for now

Do not use HoverTipFactory.FromKeyword. Build the tooltip yourself and set the prefix:

LocString description = keyword.GetDescription();
description.Add("energyPrefix", EnergyIconHelper.GetPrefix(ModelDb.CardPool<MyCardPool>()));
IHoverTip tip = new HoverTip(keyword.GetTitle(), description);

I tested this. It works in a run and in the card library:

Real fix

I opened #344. It lets a keyword declare which pool its icon comes from:

[KeywordProperties(AutoKeywordPosition.None, Pool = typeof(MyCardPool))]
public static CardKeyword MyKeyword;

[Kakamisan]

Good catch! I was testing this while running the game on a modded character, but I can reproduce the issue you found from the main menu card library. Here's a short description of the root cause:

BaseLib gives the keyword tooltip an empty energy prefix:

// CustomTooltips.cs
description.Add("energyPrefix", "");
When the prefix is empty, the game asks the current character for the icon:

// EnergyIconsFormatter
if (string.IsNullOrEmpty(text) || text == "colorless")
text = RunManager.Instance.GetLocalCharacterEnergyIconPrefix();
In a run, there is a character, so the icon is correct. In the card library there is no run, so this returns null. That is why you get the colorless icon and the warning.

Card descriptions work because they do not use the run. They use the card's own pool:

// CardModel.cs
description.Add("energyPrefix", EnergyIconHelper.GetPrefix(this));
Workaround for now

Do not use HoverTipFactory.FromKeyword. Build the tooltip yourself and set the prefix:

LocString description = keyword.GetDescription();
description.Add("energyPrefix", EnergyIconHelper.GetPrefix(ModelDb.CardPool()));
IHoverTip tip = new HoverTip(keyword.GetTitle(), description);

I tested this. It works in a run and in the card library:

**Real fix**

I opened #344. It lets a keyword declare which pool its icon comes from:

[KeywordProperties(AutoKeywordPosition.None, Pool = typeof(MyCardPool))]
public static CardKeyword MyKeyword;

good job!