Skip to content

Fix this snapshot bug and then fix the 0.4.5 release #337

@sjspielman

Description

@sjspielman

I had released 0.4.5 but then got a very surprising R CMD CHECK failure related to anndata snapshot checks which I tried to address here: #336

However, this did not do the trick, and it seems like this is still related to caching somehow but differently. https://github.com/AlexsLemonade/scpcaTools/actions/runs/23918657040

2026-04-02T20:20:48.6879068Z ══ Failed tests ════════════════════════════════════════════════════════════════
2026-04-02T20:20:48.6879737Z ── Failure ('test-sce_to_anndata.R:41:3'): Conversion of SCE to AnnData works as expected ──
2026-04-02T20:20:48.6880350Z Adding new file snapshot: 'tests/testthat/_snaps/sce_to_anndata/anndata.h5'
2026-04-02T20:20:48.6881021Z ── Failure ('test-sce_to_anndata.R:76:3'): Conversion of SCE to AnnData works as expected ──
2026-04-02T20:20:48.6881618Z Adding new file snapshot: 'tests/testthat/_snaps/sce_to_anndata/new_anndata.h5'
2026-04-02T20:20:48.6882580Z ── Failure ('test-sce_to_anndata.R:98:3'): Conversion of SCE to AnnData works with additional arguments ──
2026-04-02T20:20:48.6883267Z Adding new file snapshot: 'tests/testthat/_snaps/sce_to_anndata/no_verbose_anndata.h5'
2026-04-02T20:20:48.6883585Z
2026-04-02T20:20:48.6883909Z ── Snapshots ───────────────────────────────────────────────────────────────────
2026-04-02T20:20:48.6884299Z To review and process snapshots locally:
2026-04-02T20:20:48.6886201Z * Run testthat::snapshot_download_gh("AlexsLemonade/scpcaTools", "23918657040") to download snapshots.
2026-04-02T20:20:48.6886838Z * Run testthat::snapshot_accept() to accept all changes.
2026-04-02T20:20:48.6887438Z * Run testthat::snapshot_review() to review

I'm sort of surprised at this point that these snapshot tests ever passed in CI, since we don't store them in _snaps and the errors seem like it wants some interactivity.

I'm tempted to rip out snapshot testing and just make sure the file was created, but first I'd like to figure out more clearly what's going on here. Either way, we would like to fix this and then delete/remake the v0.4.5 release.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions