Skip to content

Commit 4845ad2

Browse files
authored
fix(keeper): correct CPU millicores formatting in resource specs (#89)
Append 'm' suffix to keeper CPU resource values so they are correctly interpreted as millicores instead of whole CPUs. This fixes keeper pods being unschedulable due to requesting hundreds of CPUs. Also update default values from 2-3 CPUs to 100m-500m millicores.
1 parent c94ceaa commit 4845ad2

2 files changed

Lines changed: 6 additions & 6 deletions

File tree

charts/clickhouse/templates/chk.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -123,10 +123,10 @@ spec:
123123
{{- end }}
124124
resources:
125125
requests:
126-
cpu: "{{ $.Values.keeper.resources.cpuRequestsMs }}"
126+
cpu: "{{ $.Values.keeper.resources.cpuRequestsMs }}m"
127127
memory: "{{ $.Values.keeper.resources.memoryRequestsMiB }}"
128128
limits:
129-
cpu: "{{ $.Values.keeper.resources.cpuLimitsMs }}"
129+
cpu: "{{ $.Values.keeper.resources.cpuLimitsMs }}m"
130130
memory: "{{ $.Values.keeper.resources.memoryLimitsMiB }}"
131131
{{- end }}
132132
{{- if not (empty .Values.namespaceDomainPattern) }}

charts/clickhouse/values.yaml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -219,10 +219,10 @@ keeper:
219219
zoneSpread: false
220220
metricsPort: ""
221221
resources:
222-
cpuRequestsMs: 2
223-
memoryRequestsMiB: 3Gi
224-
cpuLimitsMs: 3
225-
memoryLimitsMiB: 3Gi
222+
cpuRequestsMs: 100
223+
memoryRequestsMiB: 512Mi
224+
cpuLimitsMs: 500
225+
memoryLimitsMiB: 1Gi
226226

227227
operator:
228228
# -- Whether to enable the Altinity Operator for ClickHouse.

0 commit comments

Comments
 (0)