forked from CppCXY/EmmyLuaCodeStyle
-
Notifications
You must be signed in to change notification settings - Fork 0
Expand file tree
/
Copy pathCodeStyleChecker.cpp
More file actions
291 lines (267 loc) · 10.5 KB
/
Copy pathCodeStyleChecker.cpp
File metadata and controls
291 lines (267 loc) · 10.5 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
#include "CodeFormatCore/Diagnostic/CodeStyle/CodeStyleChecker.h"
#include "CodeFormatCore/Config/LanguageTranslator.h"
#include "CodeFormatCore/Diagnostic/DiagnosticBuilder.h"
#include "CodeFormatCore/Format/Analyzer/IndentationAnalyzer.h"
#include "LuaParser/Lexer/LuaTokenTypeDetail.h"
#include "Util/format.h"
CodeStyleChecker::CodeStyleChecker() {
}
void CodeStyleChecker::Analyze(DiagnosticBuilder &d, const LuaSyntaxTree &t) {
BasicStyleCheck(d, t);
EndWithNewLine(d, t);
}
void CodeStyleChecker::BasicStyleCheck(DiagnosticBuilder &d, const LuaSyntaxTree &t) {
auto &state = d.GetState();
state.Analyze(t);
auto root = t.GetRootNode();
std::vector<LuaSyntaxNode> startNodes = {root};
state.DfsForeach(startNodes, t, [this, &d](LuaSyntaxNode &syntaxNode, const LuaSyntaxTree &t, FormatResolve &resolve) {
BasicResolve(syntaxNode, t, resolve, d);
});
}
void CodeStyleChecker::EndWithNewLine(DiagnosticBuilder &d, const LuaSyntaxTree &t) {
auto &state = d.GetState();
auto &file = t.GetFile();
auto text = file.GetSource();
if (state.GetStyle().insert_final_newline) {
if (!text.empty()) {
if (text.back() != '\n' && text.back() != '\r') {
d.PushDiagnostic(DiagnosticType::EndWithNewLine,
TextRange(text.size(), 0),
LText("must end with new line"));
}
}
} else {
if (!text.empty()) {
if (text.back() == '\n' || text.back() == '\r') {
d.PushDiagnostic(DiagnosticType::EndWithNewLine,
TextRange(text.size(), 0),
LText("can not end with new line"));
}
}
}
}
void CodeStyleChecker::BasicResolve(LuaSyntaxNode syntaxNode, const LuaSyntaxTree &t, FormatResolve &resolve,
DiagnosticBuilder &d) {
if (syntaxNode.IsToken(t)) {
auto textRange = syntaxNode.GetTextRange(t);
if (d.GetState().IsNewLine(syntaxNode, t)) {
ProcessIndentDiagnostic(syntaxNode, t, d);
}
switch (resolve.GetPrevSpaceStrategy()) {
case PrevSpaceStrategy::AlignPos: {
d.ClearDiagnostic(syntaxNode.GetPrevToken(t).GetIndex());
break;
}
case PrevSpaceStrategy::AlignRelativeIndent: {
d.ClearDiagnostic(syntaxNode.GetPrevToken(t).GetIndex());
break;
}
default: {
break;
}
}
switch (resolve.GetTokenStrategy()) {
case TokenStrategy::StringSingleQuote: {
if (syntaxNode.GetTokenKind(t) == TK_STRING) {
auto text = syntaxNode.GetText(t);
if (text.size() >= 2 && text.front() == '\"' && !string_util::ExistDel('\'', text)) {
d.PushDiagnostic(DiagnosticType::StringQuote, textRange,
LText("\" should be \' "));
break;
}
}
break;
}
case TokenStrategy::StringDoubleQuote: {
if (syntaxNode.GetTokenKind(t) == TK_STRING) {
auto text = syntaxNode.GetText(t);
if (text.size() >= 2 && text.front() == '\'' && !string_util::ExistDel('\"', text)) {
d.PushDiagnostic(DiagnosticType::StringQuote, textRange,
LText("\' should be \" "));
break;
}
}
break;
}
case TokenStrategy::StmtEndSemicolon: {
switch (d.GetState().GetStyle().end_statement_with_semicolon) {
case EndStmtWithSemicolon::Never:
d.PushDiagnostic(DiagnosticType::Semicolon, textRange,
LText("Statement should not end with ;"));
break;
case EndStmtWithSemicolon::SameLine:
d.PushDiagnostic(DiagnosticType::Semicolon, textRange,
LText("; should only separate multiple statements on a single line"));
break;
default:
break;
}
break;
}
default: {
break;
}
}
switch (resolve.GetTokenAddStrategy()) {
case TokenAddStrategy::StmtEndSemicolon:
d.PushDiagnostic(DiagnosticType::Semicolon, textRange,
LText("Missing ; at end of statement"));
break;
default:
break;
}
switch (resolve.GetNextSpaceStrategy()) {
case NextSpaceStrategy::Space: {
auto nextToken = syntaxNode.GetNextToken(t);
if (nextToken.IsToken(t) && nextToken.GetStartLine(t) == syntaxNode.GetEndLine(t)) {
ProcessSpaceDiagnostic(syntaxNode, nextToken, resolve.GetNextSpace(), t, d);
}
break;
}
case NextSpaceStrategy::LineBreak: {
break;
}
default: {
break;
}
}
}
if (syntaxNode.IsNode(t)) {
auto textRange = syntaxNode.GetTextRange(t);
switch (resolve.GetTokenStrategy()) {
case TokenStrategy::StmtEndSemicolon: {
d.PushDiagnostic(DiagnosticType::Indent, textRange, LText("semicolon diagnostic"));
break;
}
default: {
break;
}
}
}
}
void CodeStyleChecker::ProcessSpaceDiagnostic(LuaSyntaxNode &node, LuaSyntaxNode &next, size_t shouldSpace,
const LuaSyntaxTree &t, DiagnosticBuilder &d) {
auto leftOffset = node.GetTextRange(t).GetEndOffset();
auto rightOffset = next.GetTextRange(t).StartOffset;
if (rightOffset < leftOffset + 1) {
return;
}
std::size_t diff = rightOffset - leftOffset - 1;
if (diff == shouldSpace) {
return;
}
auto additional = GetAdditionalNote(node, next, t);
switch (shouldSpace) {
case 0: {
d.PushDiagnostic(DiagnosticType::Space,
node.GetIndex(),
TextRange(leftOffset + 1, diff),
util::format(LText("unnecessary whitespace {}"), additional));
break;
}
case 1: {
if (diff == 0) {
d.PushDiagnostic(DiagnosticType::Space,
node.GetIndex(),
TextRange(leftOffset, 2),
util::format(LText("missing whitespace {}"), additional));
} else {
d.PushDiagnostic(DiagnosticType::Space,
node.GetIndex(),
TextRange(leftOffset + 1, diff),
util::format(LText("multiple spaces {}"), additional));
}
break;
}
default: {
if (diff < shouldSpace) {
d.PushDiagnostic(DiagnosticType::Space, node.GetIndex(),
TextRange(leftOffset, diff + 1),
util::format(LText("expected {} whitespace, found {} {}"),
shouldSpace, diff, additional));
} else {
d.PushDiagnostic(DiagnosticType::Space, node.GetIndex(),
TextRange(leftOffset + 1, diff),
util::format(LText("expected {} whitespace, found {} {}"),
shouldSpace, diff, additional));
}
}
}
}
std::string CodeStyleChecker::GetAdditionalNote(LuaSyntaxNode &left, LuaSyntaxNode &right, const LuaSyntaxTree &t) {
switch (left.GetTokenKind(t)) {
case TK_STRING:
case TK_LONG_STRING:
case TK_LONG_COMMENT:
case TK_SHORT_COMMENT:
case TK_NAME: {
break;
}
default: {
return util::format("after token '{}'", left.GetText(t));
}
}
switch (right.GetTokenKind(t)) {
case TK_STRING:
case TK_LONG_STRING:
case TK_LONG_COMMENT:
case TK_SHORT_COMMENT:
case TK_NAME: {
return "";
}
default: {
return util::format("before token '{}'", right.GetText(t));
}
}
}
void CodeStyleChecker::ProcessIndentDiagnostic(LuaSyntaxNode &node, const LuaSyntaxTree &t, DiagnosticBuilder &d) {
auto textRange = node.GetTextRange(t);
auto &state = d.GetState();
auto &file = t.GetFile();
auto indentAnalyzer = state.GetAnalyzer<IndentationAnalyzer>();
if (indentAnalyzer) {
indentAnalyzer->MarkIndent(node, t);
}
auto indent = state.GetCurrentIndent();
auto currentIndentRange = file.GetIndentRange(textRange.StartOffset);
auto currentIndentString = file.Slice(currentIndentRange);
struct CheckIndent {
std::size_t Tab = 0;
std::size_t Space = 0;
} checkIndent;
enum class ParseState {
Tab,
Space,
} parseState = ParseState::Tab;
for (auto c: currentIndentString) {
switch (parseState) {
case ParseState::Tab: {
if (c == '\t') {
checkIndent.Tab++;
} else {
checkIndent.Space++;
parseState = ParseState::Space;
}
break;
}
case ParseState::Space: {
checkIndent.Space++;
}
}
}
if (indent.TabSize != checkIndent.Tab || indent.SpaceSize != checkIndent.Space) {
d.PushDiagnostic(DiagnosticType::Indent,
currentIndentRange,
util::format("{}, found {} whitespace, {} tab",
GetIndentNote(indent, state.GetStyle().indent_style),
checkIndent.Space, checkIndent.Tab));
}
}
std::string CodeStyleChecker::GetIndentNote(IndentState indent, IndentStyle style) {
if (style == IndentStyle::Tab) {
return util::format("expected {} tab indent", indent.TabSize);
} else {
return util::format("expected {} whitespace indent", indent.SpaceSize);
}
}