-
-
Notifications
You must be signed in to change notification settings - Fork 167
Surface config save failures in the GUI #384
Copy link
Copy link
Open
Labels
area: configConfiguration files, persistence, and settingsConfiguration files, persistence, and settingsarea: guiGraphical user interfaceGraphical user interfacetype: enhancementImprovement to existing functionalityImprovement to existing functionality
Description
Metadata
Metadata
Assignees
Labels
area: configConfiguration files, persistence, and settingsConfiguration files, persistence, and settingsarea: guiGraphical user interfaceGraphical user interfacetype: enhancementImprovement to existing functionalityImprovement to existing functionality
state.rs'spersist_and_reloadand ~9 sibling sites treatsave_atomic()failure aswarn!+ continue: the UI keeps the in-memory value, the user sees success, and the setting silently reverts on restart (read-only config dir, disk full, …).Policy proposal: a one-shot, non-blocking notification (gpui-component has a toast/notification primitive) the first time a save fails, per outage — not per keystroke. Keeping the in-memory value and skipping the agent reload on failure stays as is (that ordering is deliberate and documented).
Needs a new user-facing string, i.e. an ordered-position insert across all 20 locale files plus Crowdin seeding — which is why it was split out of #381.