Skip to content

Tests shouldn't rely on a real AD instance #65

Description

@jzohrab

@Arcath, I have a suggestion and wanted to run it by you before I invest any time in this. When working on specs I generally prefer to mock out external systems as a) it's too much of a hassle to work with a real AD, b) I don't want to screw up and run tests against a real AD system, and c) it's hard to fake issues with that ext. system.

Have you thought about mocking the Net::LDAP call(s), and replacing them with fakes? This could get to be a hassle to do for the tests, but it may not. I can spend a few mins looking into it, but if you're against the idea and would reject the pull request, I won't.

Thanks for providing the gem, I tested it out in a script and it looks good. jz

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions