Skip to content

Commit 3edece3

Browse files
committed
remove: T4 auto-optimizations detection — use standard Applio/VRVC approach
Neither Applio nor Vietnamese-RVC have T4-specific detection or optimizations. They just use standard CUDA with cache_data_in_gpu as a user option. Our T4 detection added unnecessary special-casing that didn't improve training quality. Removed: - _is_t4 detection block in train.py - T4 log message in training startup - T4-specific GPU class reporting in cli.py (show_info + version) - T4 mention in README Colab table Kept: ZLUDA detection (this is genuinely needed for AMD GPU support)
1 parent b8990cf commit 3edece3

3 files changed

Lines changed: 3 additions & 21 deletions

File tree

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -102,7 +102,7 @@ rvc-cli --help
102102

103103
| Notebook | Description |
104104
|----------|-------------|
105-
| [![Open in Colab](https://colab.research.google.com/assets/colab-badge.svg)](https://colab.research.google.com/github/ArkanDash/Advanced-RVC-Inference/blob/master/Advanced-RVC.ipynb) | Full Web UI with T4 auto-optimizations |
105+
| [![Open in Colab](https://colab.research.google.com/assets/colab-badge.svg)](https://colab.research.google.com/github/ArkanDash/Advanced-RVC-Inference/blob/master/Advanced-RVC.ipynb) | Full Web UI |
106106
| [![Open in Colab](https://colab.research.google.com/assets/colab-badge.svg)](https://colab.research.google.com/github/ArkanDash/Advanced-RVC-Inference/blob/master/colab-noui.ipynb) | CLI only — lightweight headless mode |
107107

108108
---

arvc/api/cli.py

Lines changed: 2 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -103,16 +103,13 @@ def show_version():
103103
version_info.append(f"CUDA: {torch.version.cuda}")
104104
gpu_mem = torch.cuda.get_device_properties(0).total_memory // (1024**3)
105105
version_info.append(f"GPU Memory: {gpu_mem} GB")
106-
# ZLUDA / T4 detection
106+
# ZLUDA detection
107107
try:
108108
from arvc.engine.models.backends import zluda
109109
if zluda.is_available():
110110
version_info.append(f"ZLUDA: Detected (AMD GPU via CUDA compatibility)")
111111
except ImportError:
112112
pass
113-
gpu_name = torch.cuda.get_device_name(0).lower()
114-
if "t4" in gpu_name or "tesla t4" in gpu_name:
115-
version_info.append(f"GPU: Tesla T4 (T4 optimizations active)")
116113
except ImportError:
117114
version_info.append("PyTorch: Not installed")
118115

@@ -163,12 +160,7 @@ def show_info():
163160
info.append(f" Backend: HIP/ROCm (via ZLUDA)")
164161
except ImportError:
165162
pass
166-
# T4 detection
167-
gpu_name_lower = gpu_name.lower()
168-
if "t4" in gpu_name_lower or "tesla t4" in gpu_name_lower:
169-
info.append(f" GPU Class: Tesla T4 (T4-optimized training defaults)")
170-
else:
171-
info.append(f" GPU Class: Standard ({gpu_mem}GB)")
163+
info.append(f" GPU Class: Standard ({gpu_mem}GB)")
172164
else:
173165
info.append(" CUDA Available: False")
174166
except ImportError:

arvc/engine/training/runner/train.py

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -45,14 +45,6 @@
4545
# ZLUDA detection: True when running on AMD GPU via CUDA compatibility layer
4646
_is_zluda = zluda.is_available()
4747

48-
# T4 detection for Colab-friendly defaults
49-
_is_t4 = False
50-
try:
51-
if torch.cuda.is_available():
52-
_gpu_name = torch.cuda.get_device_name(0).lower()
53-
_is_t4 = "t4" in _gpu_name or "tesla t4" in _gpu_name
54-
except Exception:
55-
pass
5648
from arvc.utils.variables import logger, translations as _raw_translations
5749

5850
# ── BULLETPROOF SAFETY NET ──
@@ -543,8 +535,6 @@ def run(
543535
if rank == 0:
544536
if _is_zluda:
545537
logger.info(f"Training on ZLUDA (AMD GPU): {zluda.device_name(0)}")
546-
elif _is_t4:
547-
logger.info(f"Training on T4 GPU — using T4-optimized defaults (FP16, grad accumulation)")
548538

549539
writer_eval = SummaryWriter(
550540
log_dir=eval_dir

0 commit comments

Comments
 (0)