fix: Gradio 6.0 compat and list.keys() error (closes #71)

- Fix Gradio 6.0 deprecation: move theme/js from Blocks() to launch()
  with version detection for backward compatibility
- Fix variables.py: populate model_options from CSV data, add defensive
  isinstance() checks for vr_models/mdx_models/karaoke_models/
  reverb_models/denoise_models to prevent .keys() on non-dict types
- Fix downloads.py: use list(model_options.keys()) for CSV dropdown
  choices instead of passing dict or list directly
- Fix separate.py: add empty-dict guards on .keys() calls for
  karaoke_models, reverb_models, denoise_models
- Fix create_dataset.py: add empty-dict guards on .keys() calls
- Fix feedback.py: add isinstance() guard for MODEL_TYPES
- Fix process.py: add isinstance() check in update_sample_rate_dropdown
- Add better error traceback in gui.py exception handler
- Add packaging>=23.0 to requirements.txt for version detection

Author: BF667

arvc/app/gui.py

@@ -98,11 +98,18 @@ def launch(
         start_time = time.time()
 
         # Build the UI
-        with gr.Blocks(
-            title=f"Advanced RVC Inference",
-            theme=theme,
-            js=js_code if client_mode else None,
-        ) as app:
+        # Gradio 6.0+ moved theme/js to launch(); we pass them to
+        # Blocks() only if the installed version still accepts them.
+        import packaging.version as pv
+        _gradio_ver = pv.parse(gr.__version__)
+        _use_blocks_theme = _gradio_ver < pv.parse("6.0")
+
+        blocks_kwargs = dict(title="Advanced RVC Inference")
+        if _use_blocks_theme:
+            blocks_kwargs["theme"] = theme
+            blocks_kwargs["js"] = js_code if client_mode else None
+
+        with gr.Blocks(**blocks_kwargs) as app:
             gr.HTML(
                 f"<h1 style='text-align: center;'>Advanced RVC Inference</h1>"
             )
@@ -148,6 +155,20 @@ def launch(
         # Launch the app
         logger.info("Starting Gradio server...")
 
+        # Gradio 6.0+ accepts theme/js in launch()
+        launch_kwargs = dict(
+            server_name=server_name,
+            server_port=port,
+            show_error=show_error,
+            inbrowser=inbrowser or "--open" in sys.argv,
+            share=share,
+            allowed_paths=allowed_paths_list,
+        )
+        if not _use_blocks_theme:
+            launch_kwargs["theme"] = theme
+            if client_mode:
+                launch_kwargs["js"] = js_code
+
         # Build allowed paths list - include package assets directory
         def get_package_assets_path():
             """Get assets directory path, handling both source and installed cases."""
@@ -190,14 +211,7 @@ def get_package_assets_path():
         logger.debug(f"Allowed paths: {allowed_paths_list}")
 
         try:
-            app.launch(
-                server_name=server_name,
-                server_port=port,
-                show_error=show_error,
-                inbrowser=inbrowser or "--open" in sys.argv,
-                share=share,
-                allowed_paths=allowed_paths_list,
-            )
+            app.launch(**launch_kwargs)
 
             # Log successful startup
             startup_time = time.time() - start_time
@@ -216,15 +230,20 @@ def get_package_assets_path():
                 logger.info("Retrying with share=False (local access only)...")
 
                 # Try again without share
-                app.launch(
-                    theme=theme,
+                retry_kwargs = dict(
                     server_name=server_name,
                     server_port=port,
                     show_error=show_error,
                     inbrowser=False,
                     share=False,
                     allowed_paths=allowed_paths_list,
                 )
+                if not _use_blocks_theme:
+                    retry_kwargs["theme"] = theme
+                    if client_mode:
+                        retry_kwargs["js"] = js_code
+
+                app.launch(**retry_kwargs)
 
                 logger.warning("Share link disabled - using local access only")
                 logger.info(f"Access locally at: http://{server_name}:{port}")
@@ -254,7 +273,9 @@ def get_package_assets_path():
             logger.error(f"Failed to start server: {e}")
         return 1
     except Exception as e:
+        import traceback
         logger.error(f"Failed to launch web interface: {e}")
+        logger.debug(traceback.format_exc())
         logger.info("Try running with: rvc-gui --share=False")
         return 1
 
@@ -270,6 +291,7 @@ def create_app():
 
     try:
         import gradio as gr
+        import packaging.version as pv
 
         from arvc.utils.variables import (
             config,
@@ -282,12 +304,15 @@ def create_app():
         from arvc.app.mainjs import js_code
 
         client_mode = "--client" in sys.argv
+        _gradio_ver = pv.parse(gr.__version__)
+        _use_blocks_theme = _gradio_ver < pv.parse("6.0")
+
+        blocks_kwargs = dict(title="Advanced RVC Inference")
+        if _use_blocks_theme:
+            blocks_kwargs["theme"] = theme
+            blocks_kwargs["js"] = js_code if client_mode else None
 
-        with gr.Blocks(
-            title="Advanced RVC Inference",
-            js=js_code if client_mode else None,
-            theme=theme,
-        ) as app:
+        with gr.Blocks(**blocks_kwargs) as app:
             gr.HTML("<h1 style='text-align: center;'>Advanced RVC Inference</h1>")
 
             from arvc.app.tabs.inference.inference import inference_tab

arvc/app/tabs/downloads/downloads.py

@@ -66,7 +66,7 @@ def download_tab():
             # CSV download section
             with gr.Row(visible=False) as csv_row:
                 download_csv_model = gr.Dropdown(
-                    choices=list(model_name.keys()) if model_name else [],
+                    choices=list(model_options.keys()) if model_options else (model_name if model_name else []),
                     label=translations.get("select_model", "Select Model"),
                     interactive=True,
                 )

arvc/app/tabs/inference/child/separate.py

@@ -23,10 +23,10 @@ def separate_tab():
                     high_end_process = gr.Checkbox(label=translations["high_end_process"], value=False, interactive=False)
                     enable_post_process = gr.Checkbox(label=translations["enable_post_process"], value=False, interactive=False)
                 with gr.Row():
-                    model_name = gr.Dropdown(label=translations["separator_model"], value=uvr_model[0], choices=uvr_model, interactive=True)
-                    karaoke_model = gr.Dropdown(label=translations["separator_backing_model"], value=list(karaoke_models.keys())[0], choices=list(karaoke_models.keys()), interactive=True, visible=separate_backing.value)
-                    reverb_model = gr.Dropdown(label=translations["dereveb_model"], value=list(reverb_models.keys())[0], choices=list(reverb_models.keys()), interactive=True, visible=separate_reverb.value)
-                    denoise_model = gr.Dropdown(label=translations["denoise_model"], value=list(denoise_models.keys())[0], choices=list(denoise_models.keys()), interactive=True, visible=enable_denoise.value and model_name.value in list(vr_models.keys()))
+                    model_name = gr.Dropdown(label=translations["separator_model"], value=uvr_model[0] if uvr_model else "", choices=uvr_model, interactive=True)
+                    karaoke_model = gr.Dropdown(label=translations["separator_backing_model"], value=list(karaoke_models.keys())[0] if karaoke_models else "", choices=list(karaoke_models.keys()), interactive=True, visible=separate_backing.value)
+                    reverb_model = gr.Dropdown(label=translations["dereveb_model"], value=list(reverb_models.keys())[0] if reverb_models else "", choices=list(reverb_models.keys()), interactive=True, visible=separate_reverb.value)
+                    denoise_model = gr.Dropdown(label=translations["denoise_model"], value=list(denoise_models.keys())[0] if denoise_models else "", choices=list(denoise_models.keys()), interactive=True, visible=enable_denoise.value and model_name.value in list(vr_models.keys()))
     with gr.Row():
         with gr.Column():
             drop_audio = gr.Files(label=translations["drop_audio"], file_types=file_types)    

arvc/app/tabs/training/child/create_dataset.py

@@ -28,9 +28,9 @@ def create_dataset_tab():
     with gr.Row():
         create_dataset_button = gr.Button(translations["createdataset"], variant="primary", scale=2, min_width=4000)
     with gr.Row(visible=False) as row_2:
-        model_name = gr.Dropdown(label=translations["separator_model"], value=uvr_model[0], choices=uvr_model, interactive=True)
-        reverb_model = gr.Dropdown(label=translations["dereveb_model"], value=list(reverb_models.keys())[0], choices=list(reverb_models.keys()), interactive=True)
-        denoise_model = gr.Dropdown(label=translations["denoise_model"], value=list(denoise_models.keys())[0], choices=list(denoise_models.keys()), interactive=True, visible=False)
+        model_name = gr.Dropdown(label=translations["separator_model"], value=uvr_model[0] if uvr_model else "", choices=uvr_model, interactive=True)
+        reverb_model = gr.Dropdown(label=translations["dereveb_model"], value=list(reverb_models.keys())[0] if reverb_models else "", choices=list(reverb_models.keys()), interactive=True)
+        denoise_model = gr.Dropdown(label=translations["denoise_model"], value=list(denoise_models.keys())[0] if denoise_models else "", choices=list(denoise_models.keys()), interactive=True, visible=False)
     with gr.Row():
         with gr.Column(visible=False) as row_3:
             with gr.Group():

arvc/services/process.py

@@ -266,4 +266,7 @@ def update_sample_rate_dropdown(model):
     data = fetch_pretrained_data()
     if not data or model not in data:
         return {"choices": [], "value": None, "__type__": "update"}
-    if model != translations["success"]: return {"choices": list(data[model].keys()), "value": list(data[model].keys())[0], "__type__": "update"}
+    model_data = data[model]
+    if not isinstance(model_data, dict):
+        return {"choices": [], "value": None, "__type__": "update"}
+    if model != translations["success"]: return {"choices": list(model_data.keys()), "value": list(model_data.keys())[0] if model_data else None, "__type__": "update"}

arvc/ui/feedback.py

@@ -53,8 +53,8 @@ def _ensure_sounddevice():
 
 # Constants for model types
 MODEL_TYPES = {
-    "vr": list(vr_models.keys()),
-    "mdx": list(mdx_models.keys()),
+    "vr": list(vr_models.keys()) if isinstance(vr_models, dict) else [],
+    "mdx": list(mdx_models.keys()) if isinstance(mdx_models, dict) else [],
 }
 
 # Constants for F0 methods that require hop length

arvc/utils/variables.py

@@ -289,9 +289,9 @@ def setup_logging(config: Config):
     pass
 
 # Global state
-models = {}
-model_name = {}
-model_options = {}
+models = {}       # {filename: url}  — populated from CSV by _load_model_urls()
+model_name = {}   # reassigned below to List[str] via _list_model_names()
+model_options = {}  # {display_name: url}  — populated by search_models() & _load_model_urls()
 
 # F0 methods
 method_f0 = [
@@ -525,14 +525,24 @@ def _list_index_files(logs_path: Path) -> List[str]:
 edgetts = configs.get("edge_tts", ["vi-VN-HoaiMyNeural", "vi-VN-NamMinhNeural"])
 google_tts_voice = configs.get("google_tts_voice", ["vi", "en"])
 
-# VR models
-vr_models = configs.get("vr_models", "")
-mdx_models = configs.get("mdx_models", "")
-karaoke_models = configs.get("karaoke_models", "")
-reverb_models = configs.get("reverb_models", "")
-denoise_models = configs.get("denoise_models", "")
+# VR models — ensure they are always dicts even if config is corrupted
+_vr = configs.get("vr_models", {})
+_mdx = configs.get("mdx_models", {})
+_karaoke = configs.get("karaoke_models", {})
+_reverb = configs.get("reverb_models", {})
+_denoise = configs.get("denoise_models", {})
+
+vr_models = _vr if isinstance(_vr, dict) else {}
+mdx_models = _mdx if isinstance(_mdx, dict) else {}
+karaoke_models = _karaoke if isinstance(_karaoke, dict) else {}
+reverb_models = _reverb if isinstance(_reverb, dict) else {}
+denoise_models = _denoise if isinstance(_denoise, dict) else {}
 uvr_model = list(vr_models.keys()) + list(mdx_models.keys())
 
+# Ensure uvr_model is never empty (fallback to dict key names)
+if not uvr_model:
+    uvr_model = list(vr_models.keys()) + list(mdx_models.keys())
+
 # Sample rates
 sample_rate_choice = [8000, 11025, 12000, 16000, 22050, 24000, 32000, 44100, 48000, 96000]
 
@@ -597,3 +607,7 @@ def _load_model_urls():
 
 
 _load_model_urls()
+
+# Populate model_options from CSV data so the Downloads tab
+# "Download from CSV" dropdown is not empty.
+model_options = dict(models)  # shallow copy: {filename: url}

requirements.txt

@@ -40,6 +40,7 @@ matplotlib>=3.7.2
 
 # Implementation and web framework
 gradio>=5.23.3
+packaging>=23.0
 requests>=2.32.3
 aiohttp
 pysrt