Fix CodeRabbit AI issues and line endings

- Add arrow function export detection in react_analyzer.py
- Preserve NOT NULL/DEFAULT constraints in migrations.py
- Add DuckDNS subdomain validation in deploy.sh
- Add directory existence check in cicd.py
- Fix missing logger import and unsorted imports in projects.py
- Remove trailing whitespace in process_manager.py and websocket.py
- Add 'error' to Step type in ImportProjectModal.tsx
- Convert deploy.sh to Unix LF line endings

Author: Agent-Planner

analyzers/react_analyzer.py

@@ -362,8 +362,11 @@ def _parse_app_router_api(self, route_file: Path, api_dir: Path) -> list[Endpoin
         methods = []
         if content:
             for method in ["GET", "POST", "PUT", "PATCH", "DELETE"]:
-                if f"export async function {method}" in content or \
-                   f"export function {method}" in content:
+                # Match: export function METHOD, export async function METHOD
+                # Match: export const METHOD = (async )?(
+                if (f"export async function {method}" in content or
+                    f"export function {method}" in content or
+                    f"export const {method}" in content):
                     methods.append(method)
 
         if not methods:

api/migrations.py

@@ -93,15 +93,19 @@ def migrate_add_testing_columns(engine) -> None:
                 optional_columns = []
                 for col_name, col_info in columns.items():
                     if col_name not in core_columns:
-                        # Preserve the column with its type
-                        col_type = col_info["type"]
-                        optional_columns.append((col_name, col_type))
+                        # Preserve full column definition
+                        optional_columns.append((col_name, col_info))
 
                 # Build dynamic column definitions for optional columns
                 optional_col_defs = ""
                 optional_col_names = ""
-                for col_name, col_type in optional_columns:
-                    optional_col_defs += f",\n                        {col_name} {col_type}"
+                for col_name, col_info in optional_columns:
+                    col_def = f"{col_name} {col_info['type']}"
+                    if col_info["notnull"]:
+                        col_def += " NOT NULL"
+                    if col_info.get("dflt_value") is not None:
+                        col_def += f" DEFAULT {col_info['dflt_value']}"
+                    optional_col_defs += f",\n                        {col_def}"
                     optional_col_names += f", {col_name}"
 
                 # Step 1: Create new table without NOT NULL on testing columns

deploy.sh

@@ -71,6 +71,13 @@ derive_duckdns_subdomain() {
   else
     DUCKDNS_SUBDOMAIN="${DOMAIN}"
   fi
+
+  # Validate subdomain contains only allowed characters (alphanumeric and hyphens)
+  if ! [[ "${DUCKDNS_SUBDOMAIN}" =~ ^[a-zA-Z0-9]([a-zA-Z0-9-]*[a-zA-Z0-9])?$ ]]; then
+    echo "Invalid DuckDNS subdomain '${DUCKDNS_SUBDOMAIN}'. Must be alphanumeric with optional hyphens." >&2
+    exit 1
+  fi
+
   export DUCKDNS_SUBDOMAIN
 }
 

server/routers/cicd.py

@@ -241,6 +241,9 @@ async def get_workflow_content(project_name: str, filename: str):
     if not project_dir:
         raise HTTPException(status_code=404, detail="Project not found")
 
+    if not project_dir.exists():
+        raise HTTPException(status_code=404, detail="Project directory not found")
+
     # Security: validate filename
     if ".." in filename or "/" in filename or "\\" in filename:
         raise HTTPException(status_code=400, detail="Invalid filename")

server/routers/projects.py

@@ -6,6 +6,7 @@
 Uses project registry for path lookups instead of fixed generations/ directory.
 """
 
+import logging
 import os
 import re
 import shutil
@@ -15,6 +16,8 @@
 
 from fastapi import APIRouter, HTTPException
 
+logger = logging.getLogger(__name__)
+
 from ..schemas import (
     DatabaseHealth,
     KnowledgeFile,
@@ -370,8 +373,8 @@ async def delete_project(name: str, delete_files: bool = False):
         logger.warning(f"Error disconnecting WebSocket connections for project '{name}': {e}")
 
     # Step 2: Stop agent process manager for this project
-    from .services.process_manager import cleanup_manager as cleanup_process_manager
     from .services.dev_server_manager import get_devserver_manager
+    from .services.process_manager import cleanup_manager as cleanup_process_manager
     try:
         await cleanup_process_manager(name, project_dir)
         logger.info(f"Stopped agent process manager for project '{name}'")

server/services/process_manager.py

@@ -635,7 +635,7 @@ async def cleanup_all_managers() -> None:
 
 async def cleanup_manager(project_name: str, project_dir: Path) -> None:
     """Stop and remove a specific project's agent process manager.
-    
+
     Args:
         project_name: Name of the project
         project_dir: Absolute path to the project directory
@@ -644,7 +644,7 @@ async def cleanup_manager(project_name: str, project_dir: Path) -> None:
         # Use composite key to match get_manager
         key = (project_name, str(project_dir.resolve()))
         manager = _managers.pop(key, None)
-    
+
     if manager:
         try:
             if manager.status != "stopped":

server/websocket.py

@@ -620,18 +620,18 @@ def get_connection_count(self, project_name: str) -> int:
 
     async def disconnect_all_for_project(self, project_name: str) -> int:
         """Disconnect all WebSocket connections for a specific project.
-        
+
         Args:
             project_name: Name of the project
-            
+
         Returns:
             Number of connections that were disconnected
         """
         async with self._lock:
             connections = list(self.active_connections.get(project_name, set()))
             if project_name in self.active_connections:
                 del self.active_connections[project_name]
-        
+
         # Close connections outside the lock to avoid deadlock
         closed_count = 0
         for connection in connections:
@@ -640,7 +640,7 @@ async def disconnect_all_for_project(self, project_name: str) -> int:
                 closed_count += 1
             except Exception as e:
                 logger.warning(f"Error closing WebSocket connection for project {project_name}: {e}")
-        
+
         return closed_count
 
 

ui/src/components/ImportProjectModal.tsx

@@ -35,7 +35,7 @@ import { useCreateProject, useDeleteProject, useProjects } from '../hooks/usePro
 import { FolderBrowser } from './FolderBrowser'
 import { ConfirmDialog } from './ConfirmDialog'
 
-type Step = 'folder' | 'analyzing' | 'detected' | 'features' | 'register' | 'complete'
+type Step = 'folder' | 'analyzing' | 'detected' | 'features' | 'register' | 'complete' | 'error'
 
 interface ImportProjectModalProps {
   isOpen: boolean