From 6c912b88400b6871e9bc4c2ea401b5a6f148c602 Mon Sep 17 00:00:00 2001 From: Yann Lacroix Date: Fri, 13 Feb 2026 09:20:50 +0100 Subject: [PATCH 1/3] add httproute --- charts/cloudbeaver/templates/_helpers.tpl | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/charts/cloudbeaver/templates/_helpers.tpl b/charts/cloudbeaver/templates/_helpers.tpl index 4addf3a..789aaa2 100644 --- a/charts/cloudbeaver/templates/_helpers.tpl +++ b/charts/cloudbeaver/templates/_helpers.tpl @@ -12,3 +12,10 @@ Return the correct hostname {{- define "cloudbeaver.hostname" -}} {{- coalesce (tpl .Values.hostname $) (tpl .Values.ingress.hostname $) -}} {{- end -}} + +{{/* +Return the correct hostname +*/}} +{{- define "cloudbeaver.hostname" -}} +{{- coalesce (tpl .Values.hostname $) (tpl .Values.ingress.hostname $) -}} +{{- end -}} From a21728bff541706f1d492ebc7c836b787f07af49 Mon Sep 17 00:00:00 2001 From: Yann Lacroix Date: Tue, 10 Mar 2026 16:37:24 +0100 Subject: [PATCH 2/3] =?UTF-8?q?feat:=20=E2=9C=A8=20allow=20hostname=20to?= =?UTF-8?q?=20be=20set=20without=20using=20httproute=20or=20ingress?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- charts/kubebrowser/Chart.yaml | 2 +- charts/kubebrowser/README.md | 12 +++++++++++- charts/kubebrowser/templates/deployment.yaml | 4 +--- charts/kubebrowser/values.schema.json | 7 ++++++- charts/kubebrowser/values.yaml | 5 ++++- 5 files changed, 23 insertions(+), 7 deletions(-) diff --git a/charts/kubebrowser/Chart.yaml b/charts/kubebrowser/Chart.yaml index ab2ff65..3900e8f 100644 --- a/charts/kubebrowser/Chart.yaml +++ b/charts/kubebrowser/Chart.yaml @@ -2,7 +2,7 @@ apiVersion: v2 name: kubebrowser description: Allow whitelisted people to access your kubeconfigs type: application -version: 1.3.2 +version: 1.4.0 appVersion: "0.10.0" dependencies: - name: common diff --git a/charts/kubebrowser/README.md b/charts/kubebrowser/README.md index 5d4d799..0e7765d 100644 --- a/charts/kubebrowser/README.md +++ b/charts/kubebrowser/README.md @@ -10,6 +10,7 @@ Prepare your `values.yaml` ```yaml server: + hostname: "kubebrowser.example.com" # match your redirect URI oidc: clientID: clientSecret: @@ -28,6 +29,14 @@ Install chart helm install my-kubebrowser avisto/kubebrowser -f values.yaml ``` +## Migration guide + +### From 1.3 to 1.4 + +By default, `https` is now assumed for the `KUBEBROWSER_HOSTNAME` environment variable (used for oauth2 callback). + +Set `server.insecure=true` if you want to keep `http` prefix. + ## Parameters ### Global values @@ -95,7 +104,8 @@ helm install my-kubebrowser avisto/kubebrowser -f values.yaml | `server.hostAliases` | kubebrowser server pods host aliases | `[]` | | `server.hostNetwork` | Specify if host network should be enabled for kubebrowser pod | `false` | | `server.containerPorts.http` | kubebrowser server container port for http | `8080` | -| `server.hostname` | Hostname for kubebrowser server | `""` | +| `server.hostname` | Hostname for kubebrowser server | `localhost:8080` | +| `server.insecure` | Whether kubebrowser should expect http or https for its own hostname (e.g. for oauth2 callback) | `false` | | `server.hostIPC` | Specify if host IPC should be enabled for kubebrowser pod | `false` | | `server.labels` | Map of labels to add to the statefulset | `{}` | | `server.annotations` | Annotations for server pods | `{}` | diff --git a/charts/kubebrowser/templates/deployment.yaml b/charts/kubebrowser/templates/deployment.yaml index 3089318..59df511 100644 --- a/charts/kubebrowser/templates/deployment.yaml +++ b/charts/kubebrowser/templates/deployment.yaml @@ -86,10 +86,8 @@ spec: env: - name: GIN_MODE value: "release" - {{- if or .Values.ingress.enabled .Values.httpRoute.enabled }} - name: KUBEBROWSER_HOSTNAME - value: {{ printf "%s://%s" (ternary "https" "http" (or .Values.ingress.tls (gt (len .Values.ingress.extraTls) 0) .Values.httpRoute.enabled)) (include "kubebrowser.hostname" $) }} - {{- end }} + value: {{ printf "%s://%s" (ternary "http" "https" .Values.server.insecure) (include "kubebrowser.hostname" $) }} - name: KUBEBROWSER_OAUTH2_CLIENT_ID valueFrom: secretKeyRef: diff --git a/charts/kubebrowser/values.schema.json b/charts/kubebrowser/values.schema.json index 0cbbec6..4509af3 100644 --- a/charts/kubebrowser/values.schema.json +++ b/charts/kubebrowser/values.schema.json @@ -364,7 +364,12 @@ "hostname": { "type": "string", "description": "Hostname for kubebrowser server", - "default": "" + "default": "localhost:8080" + }, + "insecure": { + "type": "boolean", + "description": "Whether kubebrowser should expect http or https for its own hostname (e.g. for oauth2 callback)", + "default": false }, "hostIPC": { "type": "boolean", diff --git a/charts/kubebrowser/values.yaml b/charts/kubebrowser/values.yaml index 6583765..da0dd7d 100644 --- a/charts/kubebrowser/values.yaml +++ b/charts/kubebrowser/values.yaml @@ -198,7 +198,10 @@ server: http: 8080 ## @param server.hostname Hostname for kubebrowser server ## - hostname: "" + hostname: "localhost:8080" + ## @param server.insecure Whether kubebrowser should expect http or https for its own hostname (e.g. for oauth2 callback) + # + insecure: false ## @param server.hostIPC Specify if host IPC should be enabled for kubebrowser pod ## hostIPC: false From c57dd09b1ab586548ad9ac52801f420e5c39d449 Mon Sep 17 00:00:00 2001 From: Yann Lacroix Date: Tue, 10 Mar 2026 16:45:17 +0100 Subject: [PATCH 3/3] =?UTF-8?q?chore:=20=F0=9F=97=91=EF=B8=8F=20clean=20pr?= =?UTF-8?q?=20before=20submitting=20to=20review?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- charts/cloudbeaver/templates/_helpers.tpl | 7 ------- charts/kubebrowser/README.md | 2 +- charts/kubebrowser/values.schema.json | 2 +- charts/kubebrowser/values.yaml | 2 +- 4 files changed, 3 insertions(+), 10 deletions(-) diff --git a/charts/cloudbeaver/templates/_helpers.tpl b/charts/cloudbeaver/templates/_helpers.tpl index 789aaa2..4addf3a 100644 --- a/charts/cloudbeaver/templates/_helpers.tpl +++ b/charts/cloudbeaver/templates/_helpers.tpl @@ -12,10 +12,3 @@ Return the correct hostname {{- define "cloudbeaver.hostname" -}} {{- coalesce (tpl .Values.hostname $) (tpl .Values.ingress.hostname $) -}} {{- end -}} - -{{/* -Return the correct hostname -*/}} -{{- define "cloudbeaver.hostname" -}} -{{- coalesce (tpl .Values.hostname $) (tpl .Values.ingress.hostname $) -}} -{{- end -}} diff --git a/charts/kubebrowser/README.md b/charts/kubebrowser/README.md index 0e7765d..ad2a45b 100644 --- a/charts/kubebrowser/README.md +++ b/charts/kubebrowser/README.md @@ -104,7 +104,7 @@ Set `server.insecure=true` if you want to keep `http` prefix. | `server.hostAliases` | kubebrowser server pods host aliases | `[]` | | `server.hostNetwork` | Specify if host network should be enabled for kubebrowser pod | `false` | | `server.containerPorts.http` | kubebrowser server container port for http | `8080` | -| `server.hostname` | Hostname for kubebrowser server | `localhost:8080` | +| `server.hostname` | Hostname for kubebrowser server | `""` | | `server.insecure` | Whether kubebrowser should expect http or https for its own hostname (e.g. for oauth2 callback) | `false` | | `server.hostIPC` | Specify if host IPC should be enabled for kubebrowser pod | `false` | | `server.labels` | Map of labels to add to the statefulset | `{}` | diff --git a/charts/kubebrowser/values.schema.json b/charts/kubebrowser/values.schema.json index 4509af3..973a76f 100644 --- a/charts/kubebrowser/values.schema.json +++ b/charts/kubebrowser/values.schema.json @@ -364,7 +364,7 @@ "hostname": { "type": "string", "description": "Hostname for kubebrowser server", - "default": "localhost:8080" + "default": "" }, "insecure": { "type": "boolean", diff --git a/charts/kubebrowser/values.yaml b/charts/kubebrowser/values.yaml index da0dd7d..efb4323 100644 --- a/charts/kubebrowser/values.yaml +++ b/charts/kubebrowser/values.yaml @@ -198,7 +198,7 @@ server: http: 8080 ## @param server.hostname Hostname for kubebrowser server ## - hostname: "localhost:8080" + hostname: "" ## @param server.insecure Whether kubebrowser should expect http or https for its own hostname (e.g. for oauth2 callback) # insecure: false