FIX deprecated converters definitions deprecation for Symfony < 5.1

Author: AymDev

CHANGELOG.md

@@ -6,6 +6,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+## [1.3.1] - 2020-11-08
+### Fixed
+ - definition deprecation for *old* service IDs has been corrected for Symfony < 5.1
+
 ## [1.3.0] - 2020-11-07
 ### Added
  - converter names as services IDs

src/DependencyInjection/Compiler/ConvertersPass.php

@@ -10,6 +10,7 @@
 use Symfony\Component\DependencyInjection\ContainerBuilder;
 use Symfony\Component\DependencyInjection\Definition;
 use Symfony\Component\DependencyInjection\Reference;
+use Symfony\Component\HttpKernel\Kernel;
 
 /**
  * @internal
@@ -73,7 +74,14 @@ private function registerConverters(array $converterConfig, ContainerBuilder $co
 
         $deprecationMessage = 'Using the %service_id% service ID is deprecated and will be removed in v2. ';
         $deprecationMessage .= 'You should use the converter name instead.';
-        $deprecatedConverterDefinition->setDeprecated('aymdev/commonmark-bundle', '1.3.0', $deprecationMessage);
+
+        // Symfony <5.1
+        if (Kernel::MAJOR_VERSION <= 4 || (Kernel::MAJOR_VERSION === 5 && Kernel::MINOR_VERSION === 0)) {
+            $deprecatedConverterDefinition->setDeprecated(true, $deprecationMessage);
+        } else {
+            // Symfony >= 5.1
+            $deprecatedConverterDefinition->setDeprecated('aymdev/commonmark-bundle', '1.3.0', $deprecationMessage);
+        }
 
         $converterId = 'aymdev_commonmark.converter.' . $converterConfig['name'];
         $container->setDefinition($converterId, $deprecatedConverterDefinition);