Fix: Move $osArchitecture initialization before first usage in Get-TerraformTool.ps1

Copilot · jaredfholgate · Copilot · commit 2352928723dc · 2025-11-21T17:46:32.000Z
Co-authored-by: jaredfholgate &lt;1612200+jaredfholgate@users.noreply.github.com&gt;
diff --git a/src/ALZ/Private/Tools/Get-TerraformTool.ps1 b/src/ALZ/Private/Tools/Get-TerraformTool.ps1
@@ -39,19 +39,19 @@ function Get-TerraformTool {
         }
     }
 
+    $osArchitecture = Get-OSArchitecture
+
     $unzipdir = Join-Path -Path $toolsPath -ChildPath "terraform_$version"
     if (Test-Path $unzipdir) {
         Write-Verbose "Terraform $version already installed, adding to Path."
-        if($os -eq "windows") {
+        if($osArchitecture.os -eq "windows") {
             $env:PATH = "$($unzipdir);$env:PATH"
         } else {
             $env:PATH = "$($unzipdir):$env:PATH"
         }
         return
     }
 
-    $osArchitecture = Get-OSArchitecture
-
     $zipfilePath = "$unzipdir.zip"
 
     $url = $release.builds | Where-Object { $_.arch -eq $osArchitecture.architecture -and $_.os -eq $osArchitecture.os } | Select-Object -First 1 -ExpandProperty url

Original file line number	Diff line number	Diff line change
`@@ -39,19 +39,19 @@ function Get-TerraformTool {`
`39`	`39`	`}`
`40`	`40`	`}`
`41`	`41`
	`42`	`+ $osArchitecture = Get-OSArchitecture`
	`43`	`+`
`42`	`44`	`$unzipdir = Join-Path -Path $toolsPath -ChildPath "terraform_$version"`
`43`	`45`	`if (Test-Path $unzipdir) {`
`44`	`46`	`Write-Verbose "Terraform $version already installed, adding to Path."`
`45`		`- if($os -eq "windows") {`
	`47`	`+ if($osArchitecture.os -eq "windows") {`
`46`	`48`	`$env:PATH = "$($unzipdir);$env:PATH"`
`47`	`49`	`} else {`
`48`	`50`	`$env:PATH = "$($unzipdir):$env:PATH"`
`49`	`51`	`}`
`50`	`52`	`return`
`51`	`53`	`}`
`52`	`54`
`53`		`- $osArchitecture = Get-OSArchitecture`
`54`		`-`
`55`	`55`	`$zipfilePath = "$unzipdir.zip"`
`56`	`56`
`57`	`57`	`$url = $release.builds \| Where-Object { $_.arch -eq $osArchitecture.architecture -and $_.os -eq $osArchitecture.os } \| Select-Object -First 1 -ExpandProperty url`