Skip to content

Commit f688b8b

Browse files
XiaofeiCaoCopilot
andauthored
Apply suggestions from code review
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
1 parent 1ef6900 commit f688b8b

3 files changed

Lines changed: 3 additions & 3 deletions

File tree

eng/scripts/Update-Artifacts-List-For-Patch-Release.ps1

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@ foreach ($ymlFile in $ymlFiles) {
7272
}
7373
}
7474

75-
# Use OrderedDictionary here for later "FindArtifactsThatNeedPatching"
75+
# Use OrderedDictionary to preserve insertion order for deterministic processing and output.
7676
$ArtifactInfos = New-Object System.Collections.Specialized.OrderedDictionary
7777

7878
Write-Host "Loading libraries from text file."

eng/scripts/bomhelpers.ps1

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -231,7 +231,7 @@ function GitCommit($Message) {
231231
}
232232

233233
# Generate patches for given artifact patch infos.
234-
function GeneratePatches($ArtifactPatchInfos, [string]$BranchName, [string]$RemoteName, [string]$GroupId = "com.azure", [bool]$UseCurrentBranch = $false) {
234+
function GeneratePatches($ArtifactPatchInfos, [string]$BranchName, [string]$RemoteName, [string]$GroupId = "com.azure", [switch]$UseCurrentBranch) {
235235
foreach ($patchInfo in $ArtifactPatchInfos) {
236236
GeneratePatch -PatchInfo $patchInfo -BranchName $BranchName -RemoteName $RemoteName -GroupId $GroupId -UseCurrentBranch $UseCurrentBranch
237237
}

eng/scripts/patchhelpers.ps1

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -237,7 +237,7 @@ function CreateDependencyXmlElement($Artifact, [xml]$Doc) {
237237
}
238238

239239
# Generate BOM file for the given artifacts.
240-
function GenerateBOMFile($ArtifactInfos, $BomFileBranchName, [bool]$UseCurrentBranch = $false) {
240+
function GenerateBOMFile($ArtifactInfos, $BomFileBranchName, [switch]$UseCurrentBranch) {
241241
$gaArtifacts = @()
242242

243243
foreach ($artifact in $ArtifactInfos.Values) {

0 commit comments

Comments
 (0)