Skip to content
This repository was archived by the owner on Mar 20, 2023. It is now read-only.
This repository was archived by the owner on Mar 20, 2023. It is now read-only.

Merge task schema is missing completion option #366

@eedokl

Description

@eedokl

Problem Description

Currently we cannot configure completion condition behavior of merge task, it will always default to tasksuccess.
However, in my use case it can happen that the merge task fails at some point but I still want to upload its output it gave so far, so I would like to set it to taskcompletion instead.
I tried to just extend the jobs schema to also allow condition and this seems to work fine (probably since a merge task is also "just" a task which just depends on all other tasks.

Batch Shipyard Version

3.9.1

Steps to Reproduce

Set condition for merge task

Expected Results

Allow setting condition for merge task

Actual Results

  • Key 'condition' was not defined. Path: '/job_specifications/0/merge_task/output_data/azure_storage/0'.

Redacted Configuration

INSERT RELEVANT YAML FILES

Additional Logs

INSERT ADDITIONAL LOGS HERE

Additonal Comments

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions