Cuboid / trencher tool issue

[JHarris12345]

Minecraft's Version

1.20.4

Plugin's Version

2024.2-b49

Describe the bug

I have this in my config so the plugin picks up on ALL the blocks broken by cuboid tools:

other-plugins:

• InsanityFactions

However, when you break a block with a cuboid tool, it sends out MULTIPLE events per block. For example, if I break 1 coal ore with a cuboid tool, it sends out 15 block break events for it for some reason

To Reproduce

Mine a block with a cuboid tool and listen for it in an "other-plugins" plugin

Additional Information

No response

[OmerBenGera]

WildTools will simulate the BlockBreakEvent for every block that it breaks. It doesn't use the PluginManager#callEvent method tho, so only plugins that you configured to listen to the events, will listen to the events.

What exactly fires the BlockBreakEvent?

[JHarris12345]

@OmerBenGera The issue is that it fires TOO MANY times per block. I mine a 5x5x5 area and listen for every COAL_ORE break (assuming the entire 9x9x9 is coal ore), it fires like 150 times

[OmerBenGera]

It is called two times - one time for claiming plugins, one time for other-plugins.
Is InsanityFactions your plugin?

[JHarris12345]

InsanityFactions is my plugin. I have attached a video so you can see. In this video at the start I show the "ore mining" leaderboard where it shows me on 24. It basically just adds 1 for every ore broken. I break it with a trencher and it's the ONLY block broken, yet it added 24 to the amount of ores

2024-09-02.17-29-58.mp4

The code to add ores is simply just on the BlockBreakEvent add 1. The BlockBreakEvent is sent 24 times here for this 1 break

[JHarris12345]

My config is this:

  # A list of all the plugins that handle claims here on your server.
  # If one of the plugins here cancel the events, then WT will know that the player doesn't have access.
  claiming-plugins:
  - FactionsX
  - BlockLocker
  - InsanityFactions
  # A list of all the other plugins that needs to know about breaking of blocks.
  # You can add your custom shops plugins, spawners plugin and more.
  # WildTools will not care if events are cancelled from this list. Therefore, if WildTools needs to know
  # if the events are cancelled from a plugin, add it to the 'claiming-plugins' section.
  other-plugins:
  - FactionsX
  - BlockLocker
  - CoreProtect
  - InsanityCore
  - InsanityFactions```

[OmerBenGera]

My config is this:

  # A list of all the plugins that handle claims here on your server.
  # If one of the plugins here cancel the events, then WT will know that the player doesn't have access.
  claiming-plugins:
  - FactionsX
  - BlockLocker
  - InsanityFactions
  # A list of all the other plugins that needs to know about breaking of blocks.
  # You can add your custom shops plugins, spawners plugin and more.
  # WildTools will not care if events are cancelled from this list. Therefore, if WildTools needs to know
  # if the events are cancelled from a plugin, add it to the 'claiming-plugins' section.
  other-plugins:
  - FactionsX
  - BlockLocker
  - CoreProtect
  - InsanityCore
  - InsanityFactions```

Remove InsanityFactions from the claiming plugins

[JHarris12345]

Doing that reduces the amount of times it's given off but doesn't make it 1

[OmerBenGera]

In your listener, print the stacktrace and send me it here. This way I can better understand what causes this.
Make sure when you use a trench pickaxe, you only break one block, so we are not spammed.

[JHarris12345]

There is no stack trace. No error. All it does is print each block MANY times if I were to output all the block breaks

[OmerBenGera]

There is no stack trace. No error. All it does is print each block MANY times if I were to output all the block breaks

Listen to the BlockBreakEVent and print the stack trace yourself, so we can understand what called the events.

[JHarris12345]

In this video I simply hit 1 coal ore with a 5x5 cuboid tool. It only breaks 1 block (the coal ore). However, when I output the block.getType() in the BlockBreakEvent, I get this:

[14:19:52 INFO]: COAL_ORE
[14:19:52 INFO]: COAL_ORE
[14:19:52 INFO]: COAL_ORE
[14:19:52 INFO]: COAL_ORE
[14:19:52 INFO]: COAL_ORE
[14:19:52 INFO]: COAL_ORE
[14:19:52 INFO]: COAL_ORE
[14:19:52 INFO]: COAL_ORE
[14:19:52 INFO]: COAL_ORE
[14:19:52 INFO]: COAL_ORE
[14:19:52 INFO]: COAL_ORE
[14:19:52 INFO]: COAL_ORE

2024-09-13.14-19-50.mp4