Validate Mod References

[Tyler-IN]

There are some mods that depend on other mods assemblies (and immediately crash) if they are loaded.

Most developers fix that pretty quick, but there was a release of BWTournamentXP mod that had this problem.

Could you add a way to validate assembly references for submodules as well as delayed submodules?

BUTR/MnB2-Bannerlord-CommunityPatch#9

I'm interested in collaborating with you on Bannerlord community engagement to provide a good modding atmosphere.

[gallexme]

@Tyler-IN for that i would have to rewrite the launcher parts from taleworlds
atm i just add functionality to it

but adding that dependencies are downloaded with the mods + Selected is in progress
https://github.com/Bannerlord-Community-Mods/CommunityLauncher/blob/master/ModVM.cs#L66

but still waiting for the offical launcher to have a way to set the loading order

[Tyler-IN]

Dependencies aren't the same as assembly references though.

[gallexme]

Could u elaborate on that some more? Do you want a feature which checks if all referenced assembly exist and abort launch if they don't with an error message + provide a actual error message on a crash if smth went wrong in the pre launch checks? I may can do that, but it doesn't fix the problem of wrong loading orders which would make it impossible to fix for the user, apart of deselcting mods. Im pretty sure to make a good user experience for that I would have to edit the "mods" tab of the official launcher, so that depended modules + loading orders are correctly identified. +manually editable Unless u mean something different :), and I sure love contributions

…

On Wed, 8 Apr 2020, 19:36 Tyler Young ***@***.***> wrote: Dependencies aren't the same as assembly references though. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#5 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAISFLOJZVVRKLXXGGAG7I3RLSY3LANCNFSM4MBRTTIA> .

[Tyler-IN]

Check if the assembly reference is in a module's directory, ensure that the depended module element matches, otherwise provide a warning.