Skip to content

Windows ARM64 build fails: minih264e.h SIMD detection doesn't recognize MSVC ARM64 #636

Description

@BenJule

Nightly #166 (first run to include the new `windows-11-arm` target from the upstream 2.8.0 merge) fails with:

```
src/minimp4/minih264e.h(357,1): error C1189: #error: MINIH264_ONLY_SIMD used, but SSE/NEON not enabled
```

Root cause: line 339 correctly defines `MINIH264_ONLY_SIMD` for MSVC ARM64 (checks `_M_ARM64`), but the actual NEON-enabling check at line 352 only tests `__ARM_NEON`/`aarch64` - both GCC/Clang macros that MSVC never defines on ARM64 (MSVC uses `_M_ARM64` instead). So MSVC/ARM64 falls through both branches and hits the #error.

Fix: add `_M_ARM64` to the NEON-enabling condition.

Metadata

Metadata

Assignees

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions