fix(tables): fixed edge case that allowed duplicate tables to be valid

Author: BirdeeHub

src/decode.c

@@ -74,13 +74,13 @@ static bool recursive_lua_nav(
         int deftype = lua_type(L, defidx); // get the type of the new defidx
         if (key_idx < keys_end) {  // NOTE: not last key
             lua_Integer len = lua_tointeger(L, defidx);
-            lua_pop(L, 1);
             if (len < 0) {
                 TMLErr *err = new_tmlerr(L, DECODE_DEFINED_IDX);
                 set_tmlerr(err, false, 33, "value already defined inline at: ");
                 return err_push_keys(L, err, keys_start, keys_end);
             }
             if (deftype == LUA_TNUMBER) {
+                lua_pop(L, 1);
                 lua_rawgeti(L, validx, len);
                 lua_replace(L, validx);
                 lua_settop(L, validx);

tests/decode_tests.lua

@@ -163,6 +163,16 @@ key = 2
 ]]
         local data, err = tomlua_default.decode(toml_str)
         it(err ~= nil, "should error on duplicate table")
+        toml_str = [[
+[table]
+key = 1
+[table.ha]
+key = 1
+[table]
+key2 = 2
+]]
+        data, err = tomlua_default.decode(toml_str)
+        it(err ~= nil, "shouldn't forget about the duplicate tables")
         toml_str = [=[
 [fruit.oops]
 whelp = "hmmmm"