fix(sdk-core): route EdDSA MPCv2 hot wallets to full apiVersion

- `getTxRequestApiVersion`: add `|| wallet.multisigTypeVersion() === 'MPCv2'`
  to the `'full'` branch so EdDSA MPCv2 hot wallets are not incorrectly
  returned `'lite'`, which causes `signRequestBase` to fail with
  "Missing signableHex in unsignedTx" at runtime.
- `validateTxRequestApiVersion`: merge ECDSA and MPCv2 check so that
  passing `apiVersion: 'lite'` on any MPCv2 wallet throws immediately.
- `baseTSSUtils.supportedTxRequestVersions`: return `['full']` (not
  `['lite', 'full']`) for EdDSA MPCv2 hot wallets; v1 hot wallets are
  unchanged.
- Tests: add `multisigTypeVersion` to all txRequest wallet stubs; add
  two new cases (MPCv2 throws on `'lite'`, MPCv2 defaults to `'full'`);
  add `EddsaMPCv2Utils.supportedTxRequestVersions` test for MPCv2 hot
  wallet returning `['full']`.

Ticket: WCI-156
Session-Id: ac2678cb-270b-48ab-851f-7787f697cba9
Task-Id: 77a26d69-dcc5-43cf-b339-dace5e08c890

Author: Marzooqa

modules/bitgo/test/v2/unit/internal/tssUtils/eddsa.ts

@@ -15,6 +15,7 @@ import {
   common,
   createSharedDataProof,
   Ed25519BIP32,
+  EDDSAUtils,
   Eddsa,
   EncryptedSignerShareType,
   ExchangeCommitmentResponse,
@@ -1130,11 +1131,20 @@ describe('TSS Utils:', async function () {
       coldWalletTssUtils.supportedTxRequestVersions().should.deepEqual(['full']);
     });
     it('should return full and lite for hot wallets', async function () {
-      const hotWallet = new Wallet(bitgo, baseCoin, { multisigType: 'tss', type: 'hot' });
+      const hotWallet = new Wallet(bitgo, baseCoin, { multisigType: 'tss', multisigTypeVersion: undefined, type: 'hot' });
       const hotTssUtils = new TssUtils(bitgo, baseCoin, hotWallet);
       const supportedTxRequestVersions = hotTssUtils.supportedTxRequestVersions();
       supportedTxRequestVersions.should.deepEqual(['lite', 'full']);
     });
+    it('should return only full for hot MPCv2 wallets', function () {
+      const hotMPCv2Wallet = new Wallet(bitgo, baseCoin, {
+        multisigType: 'tss',
+        multisigTypeVersion: 'MPCv2',
+        type: 'hot',
+      });
+      const mpcv2TssUtils = new EDDSAUtils.EddsaMPCv2Utils(bitgo, baseCoin, hotMPCv2Wallet);
+      mpcv2TssUtils.supportedTxRequestVersions().should.deepEqual(['full']);
+    });
     it('should return empty for trading wallets', function () {
       const tradingWallets = new Wallet(bitgo, baseCoin, { multisigType: 'tss', type: 'trading' });
       const tradingWalletTssUtils = new TssUtils(bitgo, baseCoin, tradingWallets);

modules/sdk-core/src/bitgo/utils/tss/baseTSSUtils.ts

@@ -618,6 +618,9 @@ export default class BaseTssUtils<KeyShare> extends MpcUtils implements ITssUtil
     } else if (this._wallet.baseCoin.getMPCAlgorithm() === 'ecdsa') {
       return ['full'];
     } else if (this._wallet.baseCoin.getMPCAlgorithm() === 'eddsa' && this._wallet.type() === 'hot') {
+      if (this._wallet.multisigTypeVersion() === 'MPCv2') {
+        return ['full'];
+      }
       return ['lite', 'full'];
     } else {
       return ['full'];

modules/sdk-core/src/bitgo/utils/txRequest.ts

@@ -6,9 +6,8 @@ export function validateTxRequestApiVersion(wallet: IWallet, requestedApiVersion
     // only tss wallets have api version requirements
     return;
   }
-  if (wallet.baseCoin.getMPCAlgorithm() === 'ecdsa') {
-    // ecdsa wallets can only use full, even if they are hot wallets
-    assert(requestedApiVersion === 'full', 'For ECDSA tss wallets, parameter `apiVersion` must be `full`.');
+  if (wallet.baseCoin.getMPCAlgorithm() === 'ecdsa' || wallet.multisigTypeVersion() === 'MPCv2') {
+    assert(requestedApiVersion === 'full', 'For MPCv2 tss wallets, parameter `apiVersion` must be `full`.');
   } else if (wallet.type() !== 'hot') {
     // all other cases should use full!
     assert(
@@ -30,10 +29,10 @@ export function getTxRequestApiVersion(wallet: IWallet, requestedApiVersion?: Ap
     validateTxRequestApiVersion(wallet, requestedApiVersion);
     return requestedApiVersion;
   }
-  if (wallet.baseCoin.getMPCAlgorithm() === 'ecdsa') {
+  if (wallet.baseCoin.getMPCAlgorithm() === 'ecdsa' || wallet.multisigTypeVersion() === 'MPCv2') {
     return 'full';
   } else if (wallet.type() === 'hot') {
-    // default to lite for hot eddsa tss wallets
+    // default to lite for hot eddsa tss wallets (v1 only)
     return 'lite';
   } else {
     // default to full for all other wallet types

modules/sdk-core/test/unit/bitgo/utils/txRequest.ts

@@ -10,16 +10,18 @@ describe('txRequest utils', () => {
           baseCoin: { getMPCAlgorithm: () => 'ecdsa' },
           type: () => 'hot',
           multisigType: () => 'tss',
+          multisigTypeVersion: () => undefined,
         } as any as IWallet,
         requestedApiVersion: 'lite',
         expectedApiVersion: '',
-        expectedErrorMessage: 'For ECDSA tss wallets, parameter `apiVersion` must be `full`.',
+        expectedErrorMessage: 'For MPCv2 tss wallets, parameter `apiVersion` must be `full`.',
       },
       {
         wallet: {
           baseCoin: { getMPCAlgorithm: () => 'eddsa' },
           type: () => 'cold',
           multisigType: () => 'tss',
+          multisigTypeVersion: () => undefined,
         } as any as IWallet,
         requestedApiVersion: 'lite',
         expectedApiVersion: '',
@@ -30,17 +32,41 @@ describe('txRequest utils', () => {
           baseCoin: { getMPCAlgorithm: () => 'eddsa' },
           type: () => 'hot',
           multisigType: () => 'tss',
+          multisigTypeVersion: () => undefined,
         } as any as IWallet,
         requestedApiVersion: undefined,
         expectedApiVersion: 'lite',
         expectedErrorMessage: '',
       },
+      {
+        wallet: {
+          baseCoin: { getMPCAlgorithm: () => 'eddsa' },
+          type: () => 'hot',
+          multisigType: () => 'tss',
+          multisigTypeVersion: () => 'MPCv2',
+        } as any as IWallet,
+        requestedApiVersion: 'lite' as ApiVersion,
+        expectedApiVersion: '',
+        expectedErrorMessage: 'For MPCv2 tss wallets, parameter `apiVersion` must be `full`.',
+      },
+      {
+        wallet: {
+          baseCoin: { getMPCAlgorithm: () => 'eddsa' },
+          type: () => 'hot',
+          multisigType: () => 'tss',
+          multisigTypeVersion: () => 'MPCv2',
+        } as any as IWallet,
+        requestedApiVersion: undefined,
+        expectedApiVersion: 'full',
+        expectedErrorMessage: '',
+      },
       ...['hot', 'cold', 'custodial', 'backing'].map((walletType) => {
         return {
           wallet: {
             baseCoin: { getMPCAlgorithm: () => 'ecdsa' },
             type: () => walletType,
             multisigType: () => 'tss',
+            multisigTypeVersion: () => undefined,
           } as any as IWallet,
           requestedApiVersion: 'full',
           expectedApiVersion: 'full',
@@ -54,6 +80,7 @@ describe('txRequest utils', () => {
             baseCoin: { getMPCAlgorithm: () => 'ecdsa' },
             type: () => walletType,
             multisigType: () => 'tss',
+            multisigTypeVersion: () => undefined,
           } as any as IWallet,
           requestedApiVersion: undefined,
           expectedApiVersion: 'full',
@@ -67,6 +94,7 @@ describe('txRequest utils', () => {
             baseCoin: { getMPCAlgorithm: () => 'eddsa' },
             type: () => walletType,
             multisigType: () => 'tss',
+            multisigTypeVersion: () => undefined,
           } as any as IWallet,
           requestedApiVersion: 'full',
           expectedApiVersion: 'full',
@@ -80,6 +108,7 @@ describe('txRequest utils', () => {
             baseCoin: { getMPCAlgorithm: () => 'eddsa' },
             type: () => walletType,
             multisigType: () => 'tss',
+            multisigTypeVersion: () => undefined,
           } as any as IWallet,
           requestedApiVersion: undefined,
           expectedApiVersion: 'full',