feat(sdk-core): make wallet passphrase optioanl for prepareAllocation

TICKET: WCN-217

Author: alextse-bg

modules/sdk-core/src/bitgo/trading/network/network.ts

@@ -109,7 +109,7 @@ export class TradingNetwork implements ITradingNetwork {
 
   /**
    * Prepare an allocation for submission
-   * @param {string} walletPassphrase ofc wallet passphrase
+   * @param {string} walletPassphrase ofc wallet passphrase - required only when signing via user key
    * @param {string} connectionId connection to whom to make the allocation or deallocation
    * @param {string=} clientExternalId one time generated uuid v4
    * @param {string} currency currency for which the allocation should be made. e.g. btc / tbtc
@@ -130,10 +130,7 @@ export class TradingNetwork implements ITradingNetwork {
     }
 
     const payload = JSON.stringify(body);
-
-    const prv = await this.wallet.getPrv({ walletPassphrase });
-    const signedBuffer: Buffer = await this.wallet.baseCoin.signMessage({ prv }, payload);
-    const signature = signedBuffer.toString('hex');
+    const signature = await this.wallet.toTradingAccount().signPayload({ payload, walletPassphrase });
 
     return {
       ...body,

modules/sdk-core/src/bitgo/trading/network/types.ts

@@ -125,7 +125,7 @@ export type GetNetworkAllocationByIdResponse = {
 };
 
 export type PrepareNetworkAllocationParams = Omit<CreateNetworkAllocationParams, 'payload' | 'signature'> & {
-  walletPassphrase: string;
+  walletPassphrase?: string;
   clientExternalId?: string;
   nonce?: string;
 };