Commit 2648932
1bcMax
fix: don't waste 5 retries on schema errors
When o3 rejected the Task tool schema, users saw '503: 400 Invalid
schema for function Task' and the loop retried 5 times, each hitting
the same schema error. Total wait: ~30 seconds of pointless retries
before surfacing a suggestion.
The classifier saw '503' and marked it transient. But schema errors
are wrapped in 5xx responses and are NOT transient — they'll fail
identically every time.
Added a 'schema' error category that's checked BEFORE the generic 5xx
branch. Matches on: 'invalid schema', 'array schema missing items',
'invalid tool_use', 'invalid function', 'unsupported parameter',
'invalid request'. Sets isTransient: false and maxRetries: 0 so the
error surfaces immediately with the suggestion:
'Tool schema rejected by this model. Try /model to switch to a more
permissive model (e.g. sonnet), or upgrade Franklin.'
Combined with yesterday's Task schema fix + MCP sanitizer, users now
either succeed (99% case) or fail fast with actionable guidance.1 parent 6d40910 commit 2648932
4 files changed
Lines changed: 42 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
6 | 6 | | |
7 | 7 | | |
8 | 8 | | |
9 | | - | |
| 9 | + | |
10 | 10 | | |
11 | 11 | | |
12 | | - | |
| 12 | + | |
13 | 13 | | |
14 | 14 | | |
15 | 15 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
103 | 103 | | |
104 | 104 | | |
105 | 105 | | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
| 114 | + | |
| 115 | + | |
| 116 | + | |
| 117 | + | |
| 118 | + | |
| 119 | + | |
| 120 | + | |
| 121 | + | |
| 122 | + | |
| 123 | + | |
106 | 124 | | |
107 | 125 | | |
108 | 126 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | | - | |
| 3 | + | |
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
16 | 16 | | |
17 | 17 | | |
18 | 18 | | |
| 19 | + | |
19 | 20 | | |
20 | 21 | | |
21 | 22 | | |
22 | 23 | | |
23 | | - | |
| 24 | + | |
24 | 25 | | |
25 | 26 | | |
26 | 27 | | |
| |||
134 | 135 | | |
135 | 136 | | |
136 | 137 | | |
| 138 | + | |
| 139 | + | |
| 140 | + | |
| 141 | + | |
| 142 | + | |
| 143 | + | |
| 144 | + | |
| 145 | + | |
| 146 | + | |
| 147 | + | |
| 148 | + | |
| 149 | + | |
| 150 | + | |
| 151 | + | |
| 152 | + | |
| 153 | + | |
| 154 | + | |
| 155 | + | |
| 156 | + | |
137 | 157 | | |
138 | 158 | | |
139 | 159 | | |
| |||
0 commit comments