Skip to content

Expose optional ADMIN_ADDRESS env var to deploy scripts #2

@franrolotti

Description

@franrolotti

Some projects using etherform (e.g. SavingCircles) could read the admin address for upgradeable contracts from an environment variable via vm.envAddress("ADMIN_ADDRESS") in their deploy scripts.

Right now, the reusable workflows only forward PRIVATE_KEY and RPC_URL into the deploy steps, so ADMIN_ADDRESS is not available to forge script. This issue proposes adding an optional ADMIN_ADDRESS secret and wiring it through to the deploy jobs.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions