diff --git a/.github/workflows/e2e-tests.yml b/.github/workflows/e2e-tests.yml index 03462098a..dfc4b45c6 100644 --- a/.github/workflows/e2e-tests.yml +++ b/.github/workflows/e2e-tests.yml @@ -234,10 +234,11 @@ jobs: fi - name: Install Python test deps # cspell:ignore asyncio pyppeteer pytest - run: python -m pip install --upgrade pip && python -m pip install pytest pytest-asyncio pyppeteer requests + run: | + python -m pip install --upgrade pip + python -m pip install pytest pytest-asyncio pyppeteer requests + python -c "from pyppeteer.chromium_downloader import download_chromium; download_chromium()" - name: Start server and run pyppeteer tests - env: - CHROME_PATH: /usr/bin/chromium run: | python3 aria_web/server.py > /tmp/aria_server.log 2>&1 & READY=0 diff --git a/tests/test_aria_tests_workflow.py b/tests/test_aria_tests_workflow.py index df48b8c9e..f6b7d7a71 100644 --- a/tests/test_aria_tests_workflow.py +++ b/tests/test_aria_tests_workflow.py @@ -5,10 +5,25 @@ import pytest +_DOWNLOAD_CMD = 'python -c "from pyppeteer.chromium_downloader import download_chromium; download_chromium()"' + + @pytest.mark.unit def test_pyppeteer_workflow_uses_supported_chromium_download_command() -> None: workflow_path = Path(__file__).resolve().parents[1] / ".github" / "workflows" / "aria-tests.yml" content = workflow_path.read_text(encoding="utf-8") assert "python -m pyppeteer install" not in content - assert 'python -c "from pyppeteer.chromium_downloader import download_chromium; download_chromium()"' in content + assert _DOWNLOAD_CMD in content + + +@pytest.mark.unit +def test_e2e_tests_workflow_uses_pyppeteer_bundled_chromium() -> None: + """e2e-tests.yml containerized_chrome job must not try to apt-install chromium.""" + workflow_path = Path(__file__).resolve().parents[1] / ".github" / "workflows" / "e2e-tests.yml" + content = workflow_path.read_text(encoding="utf-8") + + # Must use pyppeteer bundled download — never apt-install chromium-browser (not in Bullseye) + assert "chromium-browser" not in content + assert "python -m pyppeteer install" not in content + assert _DOWNLOAD_CMD in content