Skip to content

Commit 62f2773

Browse files
Merge pull request #64 from NenoR96/revert
fix: hide image placeholders if no image
2 parents 8c41ef6 + 913cae7 commit 62f2773

5 files changed

Lines changed: 7 additions & 9 deletions

File tree

widget/templates/Item_List_1.html

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,10 +18,9 @@
1818
</p>
1919
<div class="list-item" ng-repeat="item in WidgetHome.released" ng-if="isFetchedAllData" ng-class="shouldLockItem(item.data.rank)" id="{{ 'seminarItem' + item.data.rank }}">
2020
<div class="item-click-holder ellipsis" ng-click="WidgetHome.openDetails(item.id, item.data.rank, $index)">
21-
<div class="square-icon list-media-holder">
21+
<div class="square-icon list-media-holder" ng-if="item.data.listImage || (!item.data.listImage && shouldLockItem(item.data.rank) === 'locked')">
2222
<img ng-if="item.data.listImage" class="border-radius-three" load-image="1x1" crop-width="60" crop-height="60"
2323
crop-type="crop" data-final-src="{{item.data.listImage}}">
24-
<img ng-if="!item.data.listImage" class="border-radius-three" src="../../../styles/media/holder-1x1.png">
2524
<div class="image-overlay">
2625
<div>
2726
<img src="./images/lock-icon.svg">

widget/templates/Item_List_2.html

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,10 +21,10 @@
2121
</p>
2222
<div class="list-item" ng-repeat="item in WidgetHome.released" ng-if="isFetchedAllData" ng-class="shouldLockItem(item.data.rank)" id="{{ 'seminarItem' + item.data.rank }}">
2323
<div class="item-click-holder ellipsis" ng-click="WidgetHome.openDetails(item.id, item.data.rank, $index)">
24-
<div class="list-media-holder">
24+
<div class="list-media-holder" ng-if="item.data.listImage || (!item.data.listImage && shouldLockItem(item.data.rank) === 'locked')">
2525
<img ng-if="item.data.listImage" class="border-radius-three" load-image="16x9" crop-width="120" crop-height="70"
2626
crop-type="crop" data-final-src="{{item.data.listImage}}">
27-
<img ng-if="!item.data.listImage" class="border-radius-three" src="../../../styles/media/holder-16x9.png">
27+
2828
<div class="image-overlay">
2929
<div>
3030
<img src="./images/lock-icon.svg">

widget/templates/Item_List_3.html

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,10 +22,9 @@
2222
</p>
2323
<div class="list-item" ng-repeat="item in WidgetHome.released" ng-if="isFetchedAllData" ng-class="shouldLockItem(item.data.rank)" id="{{ 'seminarItem' + item.data.rank }}">
2424
<div class="item-click-holder ellipsis" ng-click="WidgetHome.openDetails(item.id, item.data.rank, $index)">
25-
<div class="square-icon list-media-holder pull-left overflow-hidden">
25+
<div class="square-icon list-media-holder pull-left overflow-hidden" ng-if="item.data.listImage || (!item.data.listImage && shouldLockItem(item.data.rank) === 'locked')">
2626
<img ng-if="item.data.listImage" class="border-radius-three" load-image="1x1" crop-width="60" crop-height="60"
2727
crop-type="crop" data-final-src="{{item.data.listImage}}">
28-
<img ng-if="!item.data.listImage" class="border-radius-three" src="../../../styles/media/holder-1x1.png">
2928
<div class="image-overlay">
3029
<div>
3130
<img src="./images/lock-icon.svg">

widget/templates/Item_List_4.html

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818

1919
<div class="plugin-banner hasBackground">
2020
<div class="plugin-slide" ng-repeat="item in WidgetHome.released" ng-if="isFetchedAllData" ng-class="shouldLockItem(item.data.rank)" id="{{ 'seminarItem' + item.data.rank }}">
21-
<img ng-hide="item.data.listImage" src="../../../styles/media/holder-16x9.png">
21+
<img ng-hide="item.data.listImage" src="../../../styles/media/holder-16x9.png" style="opacity: 0;">
2222
<img ng-show="item.data.listImage" class="border-radius-three" ng-if="item.data.listImage"
2323
load-image="16x9" crop-width="{{deviceWidth}}" crop-height="183" crop-type="crop"
2424
data-final-src="{{item.data.listImage}}">
@@ -31,7 +31,7 @@
3131
</div>
3232
</div>
3333
<div ng-hide="item.data.listImage" class="backgroundLayer"
34-
style="background:url('../../../styles/media/holder-16x9.png');"></div>
34+
style="background:url('../../../styles/media/holder-16x9.png'); opacity: 0;"></div>
3535
<div ng-show="item.data.listImage" class="backgroundLayer"
3636
style="background:url({{item.data.listImage}});"></div>
3737

widget/templates/Item_List_5.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222
<div class="plugin-banner overflow-hidden grid-item" ng-repeat="item in WidgetHome.released"
2323
ng-if="isFetchedAllData" ng-class="shouldLockItem(item.data.rank)" id="{{ 'seminarItem' + item.data.rank }}">
2424
<div class="plugin-slide">
25-
<img ng-hide="item.data.listImage" src="../../../styles/media/holder-1x1.png">
25+
<img ng-hide="item.data.listImage" src="../../../styles/media/holder-1x1.png" style="opacity: 0;">
2626
<img ng-show="item.data.listImage" ng-if="item.data.listImage" load-image="1x1" crop-width="162"
2727
crop-height="162" crop-type="crop" data-final-src="{{item.data.listImage}}">
2828
<div class="blackLayer">

0 commit comments

Comments
 (0)