Open
Conversation
…-run-every-30s Fix timesync scheduling
Karmo7
approved these changes
Jun 19, 2025
| } | ||
| var minOffset = Math.min.apply(null, timeSyncSamples); | ||
| timeSyncSamples = []; | ||
| if (Math.abs(minOffset) > 3000000000) { |
There was a problem hiding this comment.
I'd prefer the 3E9 syntax for large numbers. It is very annoying to count the zeros
| } | ||
|
|
||
| function parseCurrentTimeResponse(serverTime) { | ||
| var localNs = Date.now() * 1000000; |
| timeSyncSamples = []; | ||
| if (Math.abs(minOffset) > 3000000000) { | ||
| setTimeOffset(minOffset); | ||
| } |
There was a problem hiding this comment.
Shouldn't there be an else clause to reset the offset for the case previously due to some network issue offset was very high but now is under 3 seconds?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary