adds firmware checksum (md5) to FITS header (#51)

Author: astronomerdave

camerad/archon.cpp

@@ -1350,7 +1350,7 @@ namespace Archon {
    *
    */
   long Interface::load_acf(std::string acffile) {
-    std::string function = "Archon::Interface::load_acf";
+    const std::string function("Archon::Interface::load_acf");
     std::stringstream message;
     std::fstream filestream;  // I/O stream class
     std::string line;         // the line read from the acffile
@@ -1760,11 +1760,13 @@ namespace Archon {
       logwrite(function, "loaded Archon config file OK");
       this->firmwareloaded = true;
 
-      // add to systemkeys keyword database
+      // add firmware filename and checksum to systemkeys keyword database
       //
-      std::stringstream keystr;
-      keystr << "FIRMWARE=" << acffile << "// controller firmware";
-      this->systemkeys.addkey( keystr.str() );
+      this->systemkeys.addkey( "FIRMWARE=" + acffile + "// controller firmware" );
+
+      std::string hash;
+      md5_file( acffile, hash );
+      this->systemkeys.addkey( "FIRM_MD5=" + hash + "// MD5 checksum of firmware" );
     }
 
     // If there was an Archon error then read the Archon error log

utils/utilities.cpp

@@ -747,13 +747,9 @@ long md5_file(const std::string &filename, std::string &hash) {
         }
 
         instream.close();
-    } catch (std::ifstream::failure &e) {
-        std::cerr << "md5_file( " << filename << " ): " << e.what() << "\n";
-        hash = "ERROR";
-        return 1;
     }
     catch (std::exception &e) {
-        std::cerr << "md5_file( " << filename << " ): " << e.what() << "\n";
+        std::cerr << "ERROR md5_file( " << filename << " ): " << e.what() << "\n";
         hash = "ERROR";
         return 1;
     }
@@ -772,7 +768,6 @@ long md5_file(const std::string &filename, std::string &hash) {
 
     return 0;
 }
-
 /***** md5_file *************************************************************/