Hi!
Went to update, got an error.
My AI terminal (Warp) edited files to fix, and update was then successful. Loaded the sonar log, and it failed to process. Worse - all items in that directory (Downloads) were deleted! Luckily nothing important... d'oh!
`I can see the issue with the PINGWizard script. The problem is in how the subprocess command is being executed. The error shows that the entire command string is being treated as a single executable file path instead of being properly split into separate arguments.
Let me examine the problematic file and fix it:
/Users/tonywhite/miniconda3-py39-25.1.1-2/envs/ping/lib/python3.12/site-packages/pinginstaller/Install_Update_PINGMapper.py (1-200)
The issue in Install_Update_PINGMapper.py is that the subprocess call is not properly splitting the command string. It should pass the command as a list of arguments instead of a single string.
Let's fix the subprocess.run call in the update_pinginstaller function.
Change Needed
Instead of:
python
We should use:
python
I'll make this change for you.
Now let's also check if there's a similar issue in the update function on line 67:
Perfect! I've fixed the subprocess call issues in the PINGWizard script. The problem was that the subprocess commands were being passed as single strings instead of properly split argument lists.
The main changes made:
- Line 84: Changed subprocess.run('''"{}" run -n ping pip install pinginstaller -U'''.format(conda_key)) to subprocess.run([conda_key, 'run', '-n', 'ping', 'pip', 'install', 'pinginstaller', '-U'])
- Line 67: Changed subprocess.run('''"{}" run -n ping pip install --upgrade -i https://PySimpleGUI.net/install PySimpleGUI'''.format(conda_key)) to subprocess.run([conda_key, 'run', '-n', 'ping', 'pip', 'install', '--upgrade', '-i', 'https://PySimpleGUI.net/install', 'PySimpleGUI'])
These changes ensure that the subprocess calls properly parse the command and arguments instead of treating the entire command as a single file path.
Now you can try running ./PINGWizard.sh again and it should work properly!`
Originally posted by @vshie in CameronBodine/PINGMapper#162 (comment)
Hi!
Went to update, got an error.
My AI terminal (Warp) edited files to fix, and update was then successful. Loaded the sonar log, and it failed to process. Worse - all items in that directory (Downloads) were deleted! Luckily nothing important... d'oh!
`I can see the issue with the PINGWizard script. The problem is in how the subprocess command is being executed. The error shows that the entire command string is being treated as a single executable file path instead of being properly split into separate arguments.
Let me examine the problematic file and fix it:
/Users/tonywhite/miniconda3-py39-25.1.1-2/envs/ping/lib/python3.12/site-packages/pinginstaller/Install_Update_PINGMapper.py (1-200)
The issue in Install_Update_PINGMapper.py is that the subprocess call is not properly splitting the command string. It should pass the command as a list of arguments instead of a single string.
Let's fix the subprocess.run call in the update_pinginstaller function.
Change Needed
Instead of:
python
We should use:
python
I'll make this change for you.
Now let's also check if there's a similar issue in the update function on line 67:
Perfect! I've fixed the subprocess call issues in the PINGWizard script. The problem was that the subprocess commands were being passed as single strings instead of properly split argument lists.
The main changes made:
These changes ensure that the subprocess calls properly parse the command and arguments instead of treating the entire command as a single file path.
Now you can try running ./PINGWizard.sh again and it should work properly!`
Originally posted by @vshie in CameronBodine/PINGMapper#162 (comment)