Skip to content

Commit 03ce8d0

Browse files
authored
Merge pull request #120 from Capstone-OpenStep/hotfix/pr-status-update
fix: 깃허브에서 create, merge를 제대로 가져오지 못하는 문제 해결
2 parents f337cc3 + 7b3d01e commit 03ce8d0

2 files changed

Lines changed: 8 additions & 17 deletions

File tree

src/main/java/com/chungang/capstone/openstep/domain/Github/dto/PullRequestResponse.java

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -2,13 +2,20 @@
22

33
import java.util.List;
44

5+
import com.fasterxml.jackson.annotation.JsonProperty;
6+
57
public class PullRequestResponse {
68
public record PullRequestRes(
79
String title,
810
int number,
911
String state,
12+
1013
String url,
14+
15+
@JsonProperty("created_at")
1116
String createdAt,
17+
18+
@JsonProperty("merged_at")
1219
String mergedAt,
1320
Repository repository,
1421
ClosingIssueWrapper closingIssuesReferences
@@ -23,12 +30,6 @@ public record RelatedIssueDto(
2330
String authorAvatarUrl,
2431
LabelWrapper labels
2532
) {
26-
public List<String> flatLabelNames() {
27-
if (labels == null || labels.nodes() == null) return List.of();
28-
return labels.nodes().stream()
29-
.map(LabelNode::name)
30-
.toList();
31-
}
3233
}
3334
record Author(String login) {}
3435
record LabelWrapper(

src/main/java/com/chungang/capstone/openstep/domain/Github/service/GitHubStatusResolverServiceImpl.java

Lines changed: 1 addition & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -54,21 +54,11 @@ public TaskStatus resolveStatus(Task task, Member member) {
5454
return newStatus;
5555
}
5656

57-
// TaskStatus newStatus;
58-
// if (pr.mergedAt() != null) {
59-
// newStatus = TaskStatus.MERGED;
60-
// } else if (Objects.equals(pr.state(), "closed")) {
61-
// newStatus = TaskStatus.REJECTED;
62-
// } else if (gitHubRestService.hasReview(owner, repo, pr.number(), githubToken)) {
63-
// newStatus = TaskStatus.REVIEW;
64-
// } else {
65-
// newStatus = TaskStatus.PR; // PR 생성만 된 상태
66-
// }
6757
// 머지 or 반려 여부
6858
TaskStatus newStatus;
6959
if (pr.mergedAt() != null) {
7060
newStatus = TaskStatus.MERGED;
71-
} else if (Objects.equals(pr.state(), "closed") && pr.mergedAt() == null) {
61+
} else if (Objects.equals(pr.state(), "closed")) {
7262
newStatus = TaskStatus.REJECTED;
7363
} else if (gitHubRestService.hasReview(owner, repo, pr.number(), githubToken)) {
7464
newStatus = TaskStatus.REVIEW;

0 commit comments

Comments
 (0)