Skip to content

Commit 1237c29

Browse files
author
StijnJacobsPXL
authored
autopep8 action fixes
1 parent 0a16414 commit 1237c29

6 files changed

Lines changed: 17 additions & 11 deletions

File tree

src/app.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44

55
app = Flask(__name__)
66

7+
78
def get_students_from_csv(path):
89
student_data = pd.read_csv(path)
910
students = []
@@ -17,12 +18,14 @@ def index():
1718
title = "Software Engineering"
1819
return render_template("form.html", title=title)
1920

21+
2022
@app.route("/groups", methods=['POST'])
2123
def groups():
2224
title = "Groups"
2325
students = get_students_from_csv('temp/students.csv')
2426
return render_template("groups.html", title=title, students=students)
2527

28+
2629
@app.route('/send', methods=['POST'])
2730
def send():
2831
csv_content = request.files['csv_file']

src/helpers.py

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -7,13 +7,13 @@
77
class Helper:
88
def __init__(self):
99
self.students = None
10-
10+
1111
def setHelperStudents(self, students):
1212
self.students = students
1313

1414
def get_students_from_csv(self, path):
1515
student_data = pd.read_csv(path)
16-
self.students = [
16+
self.students = [
1717
Student(
1818
row.firstname,
1919
row.lastname,
@@ -36,7 +36,7 @@ def make_group(self, students_in_group, group_size, group_number):
3636

3737
def print_students(self):
3838
for student in self.students:
39-
x = student.name_print()
39+
x = student.name_print()
4040
print(x)
4141

4242
def get_student_by_GUID(self, GUID):
@@ -47,7 +47,6 @@ def get_student_by_id(self, id):
4747

4848
def get_students_by_name(self, given_name):
4949
return [student for student in self.students if student.given_name == given_name]
50-
50+
5151
def get_groupless_students(self):
5252
return [student for student in self.students if not student.group_number]
53-

src/main.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
from src.student import Student
44
from src.helpers import Helper
55

6+
67
def main():
78
h = Helper()
89
file_path = input("Give the path of the file: ")

src/student.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,6 @@ def add_to_group(self, group_number):
1414

1515
def info(self):
1616
return "{} {} {} \t {} \t {}".format(self.number, self.given_name, self.surname, self.email, self.gender)
17-
17+
1818
def name_print(self):
19-
return "{} {}".format(self.given_name, self.surname)
19+
return "{} {}".format(self.given_name, self.surname)

test/test_helpers.py

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44
from src.student import Student
55
from src.helpers import Helper
66

7+
78
@pytest.fixture()
89
def sut():
910
sut0 = Student(0, "m", "firstname", "lastname", "f.n@mail.com", "test12345")
@@ -13,14 +14,16 @@ def sut():
1314
sut = [sut0, sut1, sut2, sut3]
1415
yield sut
1516

17+
1618
class TestResource:
1719
def test_make_group(self, sut):
1820
helper = Helper()
1921
helper.setHelperStudents(sut)
2022
thisGroup = helper.make_group(sut, 4, 1)
2123
for student in sut:
2224
assert student.group_number == 1
23-
25+
26+
2427
def test_print_students(capfd):
2528
sut0 = Student(0, "m", "firstname", "lastname", "f.n@mail.com", "test12345")
2629
sut1 = Student(1, "m", "firstname1", "lastname1", "f1.n1@mail1.com1", "test1")
@@ -31,4 +34,4 @@ def test_print_students(capfd):
3134
helper.setHelperStudents(sut)
3235
helper.print_students()
3336
out, err = capfd.readouterr()
34-
assert out== "firstname lastname\nfirstname1 lastname1\nfirstname2 lastname2\nfirstname3 lastname3\n"
37+
assert out == "firstname lastname\nfirstname1 lastname1\nfirstname2 lastname2\nfirstname3 lastname3\n"

test/test_student.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,11 +21,11 @@ def test_studentWithGroupHasGroupNumber(self, sut):
2121
helper.setHelperStudents(student_list)
2222
helper.make_group(student_list, group_size, 1)
2323
assert sut.group_number == 1
24-
24+
2525
def test_studentInfoOutput(self, sut):
2626
infoOutput = sut.info()
2727
assert infoOutput == "0 firstname lastname \t f.n@mail.com \t m"
28-
28+
2929
def test_name_print(self, sut):
3030
simple_print = sut.name_print()
3131
assert simple_print == "firstname lastname"

0 commit comments

Comments
 (0)