Skip to content

tools/destination_lists.py is dead code but the README treats it as live #2

Description

@ymeloch

What's wrong
server.py only imports all_tools. tools/__init__.py is empty. So tools/destination_lists.py (530 lines) is never loaded - none of the tools in it actually exist at runtime. But the README's project structure lists it like it's part of the server.
It looks like an earlier version of the destination-list tools that got replaced by the versions in all_tools.py and never deleted.

Why it matters
It's confusing for anyone reading the repo, and worth noting: the dead file is the better-written one (proper Pydantic input models instead of the hand-rolled validators in all_tools.py).

Suggested Fix
Two options:

  • Delete the file, or
  • Adopt its Pydantic models and wire it in properly, then remove the duplicate logic from all_tools.py.

Either way, the README structure section should match what's actually loaded.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Fields

    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions