Currently PAGE_SIZE is a hardcoded constant equal to 4096:
|
static constexpr uint64_t PAGE_SIZE = 4096; |
Some platforms use different page sizes - e.g. NVidia recommends 64k pages for their gbXXX platforms.
Moreover, some libraries expect PAGE_SIZE to be a macro and thus force the users to redefine it via -DPAGE_SIZE=xxx. Let's consider renaming the PAGE_SIZE constant to something like kPageSize and let's automatically deduce its value - e.g. from the PAGE_SIZE macro.
Currently
PAGE_SIZEis a hardcoded constant equal to 4096:silk/include/silk/util/platform.h
Line 42 in 4a5560f
Some platforms use different page sizes - e.g. NVidia recommends 64k pages for their gbXXX platforms.
Moreover, some libraries expect PAGE_SIZE to be a macro and thus force the users to redefine it via -DPAGE_SIZE=xxx. Let's consider renaming the PAGE_SIZE constant to something like kPageSize and let's automatically deduce its value - e.g. from the PAGE_SIZE macro.