Add support for returning BaseConfig objects in plugin settings files

Author: brandonkelly

CHANGELOG.md

@@ -7,6 +7,7 @@
 
 ### Changed
 - Edit Asset pages now show the “View” button for all file types, not just images, PDFs, and text files. ([#11936](https://github.com/craftcms/cms/issues/11936))
+- Plugins’ config files can now return the plugins’ settings objects so long as they extend `craft\config\BaseConfig`.
 
 ### Fixed
 - Fixed a bug where image transforms weren’t always getting applied properly to all animation frames. ([#11937](https://github.com/craftcms/cms/pull/11937))

src/services/Plugins.php

@@ -929,9 +929,11 @@ public function createPlugin(string $handle, ?array $info = null): ?PluginInterf
                 $config['edition'] = reset($editions);
             }
 
+            // todo: Add support for passing a settings model directly into Plugin::setSettings()
+            // so we don't have to reinstantiate the object if a BaseConfig object was returned from getConfigFromFile()
             $settings = array_merge(
                 $info['settings'] ?? [],
-                Craft::$app->getConfig()->getConfigFromFile($handle)
+                (array)Craft::$app->getConfig()->getConfigFromFile($handle)
             );
 
             if ($settings !== []) {