Commit b188491
refactor: act on the structure/naming review
Addresses the high-level review's findings — internal legibility, not behavior
(review mode output is unchanged):
- rename scripts/cb_engine.py -> scripts/engine_adapter.py (+ test file): it is
a thin CLI adapter over the separate CodeBoarding engine, not the engine; the
old name implied analysis logic lived here. Docstring now says so up front.
- dedupe the incremental-or-full path: review 'head' and sync 'analyze' shared
~90% logic (try incremental, fall back to full on the same two exceptions);
both now call one _incremental_or_full helper, so a fallback fix lands once.
- move baseline parsing into the adapter: new 'baseline-info' subcommand emits
commit_hash= only when present and SHA-shaped, replacing the sync_seed step's
inline python heredoc + grep with one tested code path.
- add a 'force_full' input (sync mode) that rebuilds the baseline from scratch,
and RETIRE refresh-baseline.yml: it was a 198-line hand-rolled copy of the
action's own pipeline. Its 'fresh full rebuild' is now codeboarding-sync.yml's
workflow_dispatch + force_full, running the tested action instead of a clone.
- structure legibility: a top-of-file phase map (guard / shared setup /
analysis-with-key / drop-key + output) naming the shared analysis.json
baseline as the binding between the two modes; review-only inputs now carry a
'Review mode:' prefix so the Marketplace-rendered view matches the README.
- refresh AGENT.md (was review-only) to describe both modes; document force_full.
93 tests pass (both module orders); actionlint, shellcheck, black clean.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>1 parent 8647666 commit b188491
10 files changed
Lines changed: 359 additions & 368 deletions
File tree
- .github/workflows
- docs
- scripts
- tests
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | | - | |
2 | | - | |
3 | | - | |
4 | | - | |
5 | | - | |
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
6 | 9 | | |
7 | 10 | | |
8 | 11 | | |
| |||
12 | 15 | | |
13 | 16 | | |
14 | 17 | | |
15 | | - | |
| 18 | + | |
16 | 19 | | |
17 | 20 | | |
18 | 21 | | |
19 | 22 | | |
20 | 23 | | |
21 | 24 | | |
22 | 25 | | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
23 | 32 | | |
24 | 33 | | |
25 | | - | |
| 34 | + | |
26 | 35 | | |
27 | 36 | | |
28 | | - | |
29 | | - | |
30 | | - | |
| 37 | + | |
| 38 | + | |
31 | 39 | | |
32 | 40 | | |
33 | 41 | | |
| |||
44 | 52 | | |
45 | 53 | | |
46 | 54 | | |
| 55 | + | |
47 | 56 | | |
This file was deleted.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | | - | |
4 | | - | |
5 | | - | |
6 | | - | |
7 | | - | |
8 | | - | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
9 | 17 | | |
10 | 18 | | |
11 | 19 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
252 | 252 | | |
253 | 253 | | |
254 | 254 | | |
| 255 | + | |
255 | 256 | | |
256 | 257 | | |
257 | 258 | | |
| |||
0 commit comments