fix(e2e): harden specs with self-contained state, assertions, and diagnostics

- clickFirstMatch: poll with retry loop instead of single-pass probe
- walkOnboarding: poll 6 times before concluding overlay not mounted;
  fix button text to match current LocalAIStep ("Use Local Models");
  redact accessibility tree dumps on MnemonicStep (recovery phrase)
- navigateToBilling: verify billing markers after fallback, throw with
  diagnostics (hash + tree dump) on failure
- performFullLogin: accept optional postLoginVerifier callback for
  callers that need to assert auth side-effects
- auth-access-control: extract local nav helpers to shared-flows imports;
  seed mock state per-test (3.3.1, 3.3.3) instead of relying on prior
  specs; assert "Manage" button presence; assert waitForTextToDisappear
  result; tighten logout postcondition with token-cleared check;
  confirmation click searches role="button" + aria-label
- card-payment-flow: seed mock state per-test (5.2.1, 5.3.1, 5.3.2);
  assert "Manage" presence instead of silent skip
- crypto-payment-flow: enable crypto toggle before Upgrade, verify
  Coinbase charge endpoint; seed state per-test (6.2.1, 6.3.1)
- login-flow: track hadOnboardingWalkthrough boolean for Phase 3
  onboarding-complete assertion; expired/invalid token tests now assert
  home not reached, welcome UI visible, and token not persisted;
  bypass auth test clears state first and asserts all outcomes
- conversations: platform-gated skip (Linux only, not all platforms)
- skills-registry: assert hash + UI marker after navigateToSkills
- notion-flow: remove duplicate local waitForHomePage; add hash
  assertion after navigateToIntelligence
- e2e-run-all-flows: set OPENHUMAN_SERVICE_MOCK=1 for service spec
- docker-entrypoint: verify Xvfb liveness with retry, add cleanup trap
- mock-api-core: catch-all returns 404 instead of fake 200
- clickToggle: use clickAtElement instead of raw el.click on tauri-driver

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Author: CodeGhost21

app/scripts/e2e-run-all-flows.sh

@@ -22,7 +22,7 @@ run "test/e2e/specs/crypto-payment-flow.spec.ts" "crypto-payment"
 run "test/e2e/specs/conversations-web-channel-flow.spec.ts" "conversations"
 run "test/e2e/specs/local-model-runtime.spec.ts" "local-model"
 run "test/e2e/specs/screen-intelligence.spec.ts" "screen-intelligence"
-run "test/e2e/specs/service-connectivity-flow.spec.ts" "service-connectivity"
+OPENHUMAN_SERVICE_MOCK=1 run "test/e2e/specs/service-connectivity-flow.spec.ts" "service-connectivity"
 run "test/e2e/specs/skills-registry.spec.ts" "skills-registry"
 run "test/e2e/specs/navigation.spec.ts" "navigation"
 run "test/e2e/specs/smoke.spec.ts" "smoke"

app/test/e2e/helpers/element-helpers.ts

@@ -313,7 +313,7 @@ export async function clickToggle(_timeout: number = 15_000): Promise<void> {
     for (const sel of selectors) {
       const el = await browser.$(sel);
       if (await el.isExisting()) {
-        await el.click();
+        await clickAtElement(el);
         return;
       }
     }

app/test/e2e/helpers/shared-flows.ts

@@ -142,6 +142,21 @@ export async function navigateToBilling() {
   });
   console.log(`[E2E] Billing fallback: ${clicked}`);
   await browser.pause(3_000);
+
+  // Verify billing actually loaded after fallback
+  const finalCheck = (await textExists('Current Plan')) ||
+    (await textExists('FREE')) ||
+    (await textExists('Upgrade'));
+  if (!finalCheck) {
+    const finalHash = await browser.execute(() => window.location.hash);
+    const tree = await dumpAccessibilityTree();
+    console.log(`[E2E] Billing verification failed after fallback. Hash: ${finalHash}`);
+    console.log(`[E2E] Accessibility tree:\n`, tree.slice(0, 4000));
+    throw new Error(
+      `navigateToBilling: billing markers not found after fallback (hash: ${finalHash})`
+    );
+  }
+  console.log('[E2E] Billing page loaded (after fallback)');
 }
 
 export async function navigateToSkills() {
@@ -163,15 +178,18 @@ export async function navigateToConversations() {
 /**
  * Walk through the real onboarding steps:
  *   Step 0: WelcomeStep       — "Continue"
- *   Step 1: LocalAIStep       — "Setup later" → "Continue" (skip Ollama)
+ *   Step 1: LocalAIStep       — "Use Local Models"
  *   Step 2: ScreenPermissions — "Continue Without Permission"
  *   Step 3: ToolsStep         — "Continue"
  *   Step 4: SkillsStep        — "Finish Setup" (fires onboarding-complete)
  *   Step 5: MnemonicStep      — checkbox + "Finish Setup"
  */
 export async function walkOnboarding(logPrefix = '[E2E]') {
+  // Detect onboarding overlay. The Onboarding.tsx parent renders a "Skip" defer
+  // button (top-right), and step 0 is WelcomeStep with "Continue".
   const onboardingVisible = (await textExists('Welcome')) ||
-    (await textExists('Set up later')) ||
+    (await textExists('Skip')) ||
+    (await textExists('Use Local Models')) ||
     (await textExists('Continue'));
 
   if (!onboardingVisible) {
@@ -187,19 +205,12 @@ export async function walkOnboarding(logPrefix = '[E2E]') {
     await browser.pause(2_000);
   }
 
-  // Step 1: LocalAIStep
+  // Step 1: LocalAIStep — only has "Use Local Models" button now (no skip phase)
   {
-    const clicked = await clickFirstMatch(['Setup later', 'Use Local Models', 'Continue'], 10_000);
+    const clicked = await clickFirstMatch(['Use Local Models', 'Continue'], 10_000);
     if (clicked) {
       console.log(`${logPrefix} LocalAIStep: clicked "${clicked}"`);
       await browser.pause(2_000);
-      if (clicked === 'Setup later') {
-        const cont = await clickFirstMatch(['Continue'], 5_000);
-        if (cont) {
-          console.log(`${logPrefix} LocalAIStep (skipped): clicked "Continue"`);
-          await browser.pause(2_000);
-        }
-      }
     }
   }
 
@@ -260,7 +271,20 @@ export async function walkOnboarding(logPrefix = '[E2E]') {
 // Full login flow
 // ---------------------------------------------------------------------------
 
-export async function performFullLogin(token = 'e2e-test-token', logPrefix = '[E2E]') {
+/**
+ * @param token          Deep link token string.
+ * @param logPrefix      Prefix for console log lines.
+ * @param postLoginVerifier  Optional async callback invoked after the Home page
+ *   is confirmed.  Receives `logPrefix` so it can log consistently.  If the
+ *   verifier throws, performFullLogin propagates the error — callers can use
+ *   this to assert that auth side-effects (e.g. token consume, profile fetch)
+ *   actually occurred rather than relying on UI alone.
+ */
+export async function performFullLogin(
+  token = 'e2e-test-token',
+  logPrefix = '[E2E]',
+  postLoginVerifier?: (logPrefix: string) => Promise<void>,
+) {
   await triggerAuthDeepLink(token);
   await waitForWindowVisible(25_000);
   await waitForWebView(15_000);
@@ -275,5 +299,10 @@ export async function performFullLogin(token = 'e2e-test-token', logPrefix = '[E
     console.log(`${logPrefix} Home page not reached after login. Tree:\n`, tree.slice(0, 4000));
     throw new Error('Full login did not reach Home page');
   }
+
+  if (postLoginVerifier) {
+    await postLoginVerifier(logPrefix);
+  }
+
   console.log(`${logPrefix} Home page confirmed: found "${homeText}"`);
 }